Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support binary_logging for replica instances #4907

Merged
merged 4 commits into from
Jun 24, 2021

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Jun 22, 2021

closes hashicorp/terraform-provider-google#9371
closes hashicorp/terraform-provider-google#9166

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: add support for `binary_logging` on replica instances for `googe_sql_database_instance`

@ScottSuarez ScottSuarez requested review from a team and c2thorn and removed request for a team June 22, 2021 21:45
@google-cla google-cla bot added the cla: yes label Jun 22, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 31 insertions(+))
Terraform Beta: Diff ( 3 files changed, 32 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193211"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 34 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 34 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193213"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_withNetwork|TestAccSqlDatabaseInstance_replica You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193215"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_withNetwork|TestAccSqlDatabaseInstance_replica You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193309"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_withNetwork Please fix these to complete your PR

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 32 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 33 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_withNetwork|TestAccContainerNodePool_withGPU You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193480"

@ScottSuarez ScottSuarez merged commit 94c0a96 into GoogleCloudPlatform:master Jun 24, 2021
@ScottSuarez ScottSuarez deleted the psql branch June 24, 2021 17:35
MatthewSBarnes added a commit to MatthewSBarnes/terraform-provider-google that referenced this pull request Jan 21, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907
megan07 pushed a commit to hashicorp/magic-modules that referenced this pull request Jan 26, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907
megan07 added a commit that referenced this pull request Jan 26, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in #4907

Co-authored-by: Matthew Barnes <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Jan 26, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907

Co-authored-by: Matthew Barnes <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Jan 26, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907

Co-authored-by: Matthew Barnes <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google that referenced this pull request Jan 26, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907

Co-authored-by: Matthew Barnes <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Matthew Barnes <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this pull request Jan 26, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907

Co-authored-by: Matthew Barnes <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Matthew Barnes <[email protected]>
modular-magician added a commit to modular-magician/terraform-validator that referenced this pull request Jan 26, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907

Co-authored-by: Matthew Barnes <[email protected]>
Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to GoogleCloudPlatform/terraform-validator that referenced this pull request Jan 26, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907

Co-authored-by: Matthew Barnes <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Matthew Barnes <[email protected]>
megan07 pushed a commit to hashicorp/terraform-provider-google that referenced this pull request Jan 27, 2022
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907
tsamaras pushed a commit to wayfair-contribs/magic-modules that referenced this pull request Feb 4, 2022
…m#5649)

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907

Co-authored-by: Matthew Barnes <[email protected]>
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
…m#5649)

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907

Co-authored-by: Matthew Barnes <[email protected]>
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
…m#5649)

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907

Co-authored-by: Matthew Barnes <[email protected]>
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
…m#5649)

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907

Co-authored-by: Matthew Barnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants