-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support binary_logging for replica instances #4907
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193211" |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193213" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_withNetwork|TestAccSqlDatabaseInstance_replica You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193215" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_withNetwork|TestAccSqlDatabaseInstance_replica You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193309" |
Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_withNetwork Please fix these to complete your PR |
mmv1/third_party/terraform/resources/resource_sql_database_instance.go.erb
Outdated
Show resolved
Hide resolved
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCloudbuildWorkerPool_withNetwork|TestAccContainerNodePool_withGPU You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=193480" |
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform/magic-modules#4907
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform#4907
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in #4907 Co-authored-by: Matthew Barnes <[email protected]>
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform/magic-modules#4907 Co-authored-by: Matthew Barnes <[email protected]> Signed-off-by: Modular Magician <[email protected]>
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform/magic-modules#4907 Co-authored-by: Matthew Barnes <[email protected]> Signed-off-by: Modular Magician <[email protected]>
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform/magic-modules#4907 Co-authored-by: Matthew Barnes <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Matthew Barnes <[email protected]>
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform/magic-modules#4907 Co-authored-by: Matthew Barnes <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Matthew Barnes <[email protected]>
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform/magic-modules#4907 Co-authored-by: Matthew Barnes <[email protected]> Signed-off-by: Modular Magician <[email protected]>
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform/magic-modules#4907 Co-authored-by: Matthew Barnes <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Matthew Barnes <[email protected]>
`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform/magic-modules#4907
…m#5649) `settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform#4907 Co-authored-by: Matthew Barnes <[email protected]>
…m#5649) `settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform#4907 Co-authored-by: Matthew Barnes <[email protected]>
…m#5649) `settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform#4907 Co-authored-by: Matthew Barnes <[email protected]>
…m#5649) `settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false. This behaviour as changed in GoogleCloudPlatform#4907 Co-authored-by: Matthew Barnes <[email protected]>
closes hashicorp/terraform-provider-google#9371
closes hashicorp/terraform-provider-google#9166
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)