Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google_sql_database_instance documentation #5649

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented Jan 26, 2022

settings.backup_configuration.binary_log_enabled may be true even if settings.backup_configuration.enabled is false.

This behaviour as changed in #4907

Upstreams hashicorp/terraform-provider-google#10951

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907
@megan07 megan07 requested a review from ScottSuarez January 26, 2022 15:02
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 1 insertion(+), 2 deletions(-))

@megan07 megan07 merged commit 86b6a14 into GoogleCloudPlatform:master Jan 26, 2022
tsamaras pushed a commit to wayfair-contribs/magic-modules that referenced this pull request Feb 4, 2022
…m#5649)

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907

Co-authored-by: Matthew Barnes <[email protected]>
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
…m#5649)

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907

Co-authored-by: Matthew Barnes <[email protected]>
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
…m#5649)

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907

Co-authored-by: Matthew Barnes <[email protected]>
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
…m#5649)

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform#4907

Co-authored-by: Matthew Barnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants