Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google_sql_database_instance documentation #10951

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

MatthewSBarnes
Copy link
Contributor

@MatthewSBarnes MatthewSBarnes commented Jan 21, 2022

settings.backup_configuration.binary_log_enabled may be true even if settings.backup_configuration.enabled is false.

This behaviour was changed in GoogleCloudPlatform/magic-modules#4907

Related Material

https://cloud.google.com/sql/docs/mysql/replication#bin-log-replica
GoogleCloudPlatform/magic-modules#4907

`settings.backup_configuration.binary_log_enabled` may be true even if `settings.backup_configuration.enabled` is false.

This behaviour as changed in GoogleCloudPlatform/magic-modules#4907
@github-actions github-actions bot requested a review from megan07 January 21, 2022 20:12
Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
@MatthewSBarnes MatthewSBarnes deleted the patch-1 branch January 31, 2024 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants