Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google provider does not support binary logging on replica's #9166

Closed
Cartman75 opened this issue May 17, 2021 · 1 comment · Fixed by GoogleCloudPlatform/magic-modules#4907, #9428 or hashicorp/terraform-provider-google-beta#3379
Assignees
Labels

Comments

@Cartman75
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v0.12.31

  • provider.google v3.66.1
  • provider.google-beta v3.66.1
  • provider.random v3.1.0
  • provider.vault v2.18.0

Affected Resource(s)

google_sql_database_instance

Terraform Configuration Files

Diff:

            backup_configuration {
                binary_log_enabled             = true
                enabled                        = false
                point_in_time_recovery_enabled = false
                start_time                     = "11:00"
                transaction_log_retention_days = 7

                backup_retention_settings {
                    retained_backups = 7
                    retention_unit   = "COUNT"
                }
            }

Expected Behavior

What should happen is nothing. It should be a noop.

Actual Behavior

I get an error:

Error: Error, failed to update instance settings for : googleapi: Error 400: Invalid request: Binary log must be disabled when backup is disabled or the instance must be a replica instance with a MySQL 5.7 or above version., invalid

Steps to Reproduce

turn on binary logging with backups turned off on a MySQL 5.7 replica

  1. terraform apply

Important Factoids

I turned on binary logs on our replica via: gcloud sql instances patch --enable-bin-log. I spoke to google and this featured was enabled at the end of the year with:

  • slave_parallel_type
  • slave_parallel_workers
  • slave_preserve_commit_order

You have to turn on binary logs for commit_order. So this is a valid feature for the replica.

Here is the google doc showing its supported: https://cloud.google.com/sql/docs/mysql/replication#bin-log-replica

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.