-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor forc-pkg with generic manifest trait #5625
Commits on Dec 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 50c5471 - Browse repository at this point
Copy the full SHA 50c5471View commit details
Commits on Dec 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b7e9af3 - Browse repository at this point
Copy the full SHA b7e9af3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9322150 - Browse repository at this point
Copy the full SHA 9322150View commit details
Commits on Dec 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2a8d9fc - Browse repository at this point
Copy the full SHA 2a8d9fcView commit details
Commits on Jan 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9dc970d - Browse repository at this point
Copy the full SHA 9dc970dView commit details
Commits on Jan 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7d4cf70 - Browse repository at this point
Copy the full SHA 7d4cf70View commit details
Commits on Jan 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a3cd5a0 - Browse repository at this point
Copy the full SHA a3cd5a0View commit details
Commits on Jan 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 29eb2fc - Browse repository at this point
Copy the full SHA 29eb2fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29d4bf6 - Browse repository at this point
Copy the full SHA 29d4bf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94ca7d7 - Browse repository at this point
Copy the full SHA 94ca7d7View commit details
Commits on Jan 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c483e6 - Browse repository at this point
Copy the full SHA 9c483e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6a9a2e - Browse repository at this point
Copy the full SHA c6a9a2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa2ee38 - Browse repository at this point
Copy the full SHA fa2ee38View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef8e347 - Browse repository at this point
Copy the full SHA ef8e347View commit details -
Configuration menu - View commit details
-
Copy full SHA for 981ec6f - Browse repository at this point
Copy the full SHA 981ec6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67a86b2 - Browse repository at this point
Copy the full SHA 67a86b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 381a5d5 - Browse repository at this point
Copy the full SHA 381a5d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54e03a9 - Browse repository at this point
Copy the full SHA 54e03a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffb7fd0 - Browse repository at this point
Copy the full SHA ffb7fd0View commit details
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6eb1cf - Browse repository at this point
Copy the full SHA a6eb1cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f7d63d - Browse repository at this point
Copy the full SHA 2f7d63dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11ae91c - Browse repository at this point
Copy the full SHA 11ae91cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52b8575 - Browse repository at this point
Copy the full SHA 52b8575View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7a56ae - Browse repository at this point
Copy the full SHA e7a56aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6539626 - Browse repository at this point
Copy the full SHA 6539626View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82e9433 - Browse repository at this point
Copy the full SHA 82e9433View commit details
Commits on Jan 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3becd91 - Browse repository at this point
Copy the full SHA 3becd91View commit details
Commits on Jan 24, 2024
-
feat: implement
-o
flags for disabling optimizations (#5385)This PR implements `-o` flags so that we can disable optimizations. This will be useful as we are working towards debugger support and optimizations pollute source map generated. Provide option to the e2e test binary to specify build profile. For tests that have their ABI tested, or rely on their compiled hashes (for deployment), since that changes with build profile, the tests are marked as unsupported for debug profile. (better to test with and have expected results for release than the debug profile). Add testing release profile in CI since the default is now debug. Two tests in `should_fail` that are expected to fail due to overflows are disabled because there's a bug in our IR gen. This is tracked by #5449 --------- Co-authored-by: Vaivaswatha Nagaraj <[email protected]> Co-authored-by: Vaivaswatha N <[email protected]> Co-authored-by: Sophie Dankel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 251a61f - Browse repository at this point
Copy the full SHA 251a61fView commit details -
Forbid configurables in constants (#5497)
## Description Don't allow configurables to be used in const expressions except as storage and configurable initializers. Fix #5272 Fix #5261 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: João Matos <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 928b8d2 - Browse repository at this point
Copy the full SHA 928b8d2View commit details -
Change auto_import test to use git tag of std lib (#5501)
## Description There isn't a good reason to target the local std-lib for these tests, targeting the git tag helps reduce churn on people working on the std-lib.
Configuration menu - View commit details
-
Copy full SHA for b7c50fa - Browse repository at this point
Copy the full SHA b7c50faView commit details -
Configuration menu - View commit details
-
Copy full SHA for b154f98 - Browse repository at this point
Copy the full SHA b154f98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b7b468 - Browse repository at this point
Copy the full SHA 6b7b468View commit details -
Configuration menu - View commit details
-
Copy full SHA for 630b817 - Browse repository at this point
Copy the full SHA 630b817View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8a03a6 - Browse repository at this point
Copy the full SHA a8a03a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 258eb4f - Browse repository at this point
Copy the full SHA 258eb4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26e46cb - Browse repository at this point
Copy the full SHA 26e46cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b00bf17 - Browse repository at this point
Copy the full SHA b00bf17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dac60b - Browse repository at this point
Copy the full SHA 5dac60bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccdada2 - Browse repository at this point
Copy the full SHA ccdada2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 170fb41 - Browse repository at this point
Copy the full SHA 170fb41View commit details
Commits on Jan 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6b61819 - Browse repository at this point
Copy the full SHA 6b61819View commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62df122 - Browse repository at this point
Copy the full SHA 62df122View commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 73ae64f - Browse repository at this point
Copy the full SHA 73ae64fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f3dc5 - Browse repository at this point
Copy the full SHA a6f3dc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6f2bed - Browse repository at this point
Copy the full SHA c6f2bedView commit details -
Configuration menu - View commit details
-
Copy full SHA for c096f5b - Browse repository at this point
Copy the full SHA c096f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0de86f5 - Browse repository at this point
Copy the full SHA 0de86f5View commit details
Commits on Feb 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0c17485 - Browse repository at this point
Copy the full SHA 0c17485View commit details -
Configuration menu - View commit details
-
Copy full SHA for d840a00 - Browse repository at this point
Copy the full SHA d840a00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28c8351 - Browse repository at this point
Copy the full SHA 28c8351View commit details
Commits on Feb 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8969018 - Browse repository at this point
Copy the full SHA 8969018View commit details -
Configuration menu - View commit details
-
Copy full SHA for de8816d - Browse repository at this point
Copy the full SHA de8816dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 100a3b0 - Browse repository at this point
Copy the full SHA 100a3b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d830bd - Browse repository at this point
Copy the full SHA 5d830bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 49199c4 - Browse repository at this point
Copy the full SHA 49199c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff33454 - Browse repository at this point
Copy the full SHA ff33454View commit details
Commits on Feb 8, 2024
-
Disable DCA and writing diagnostics on did_change events (#5555)
## Description This PR does 3 optimizations. The timings below are measured against the LSP benchmarking project. 1. Disable running DCA & control flow analysis, for did_change events `39.544ms` 2. Disable running collect_types_metadata for did_change events `3.522ms` 3. Only write the diagnostics res to self.diagnostics.write() on did_open & did_save `21.135ms` I also had to increase the frequency that we are calling GC to every 3rd keystroke as during stress tests I was occasionally getting stack overflows otherwise. related to #5445 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Configuration menu - View commit details
-
Copy full SHA for 44e790e - Browse repository at this point
Copy the full SHA 44e790eView commit details -
Configuration menu - View commit details
-
Copy full SHA for df195ef - Browse repository at this point
Copy the full SHA df195efView commit details -
Fix build-mdbook CI failure (#5574)
## Description `build-mdbook` was failing on multiple PRs with ``` Run cargo install --locked --debug --path ./forc error: binary `forc` already exists in destination Add --force to overwrite ``` https://github.com/FuelLabs/sway/actions/runs/7819113568/attempts/1?pr=5569 https://github.com/FuelLabs/sway/actions/runs/7816891674/job/21336246772?pr=5565 `cargo install` keeps track of which binaries it has installed in ~/.cargo/crates.toml and ~/.cargo.crates2.json. By using the entire cached `cargo` directory, cargo is able to tell that it has previously installed the binaries and install correctly. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Configuration menu - View commit details
-
Copy full SHA for 388323b - Browse repository at this point
Copy the full SHA 388323bView commit details -
Turn struct field privacy warnings into errors (#5569)
## Description Closes #5520. As agreed with @FuelLabs/tooling, one LSP test fixture is changed to temporarily fetch its `std` dependency from the local repository. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Configuration menu - View commit details
-
Copy full SHA for 3aad2f2 - Browse repository at this point
Copy the full SHA 3aad2f2View commit details -
u256: log, log2 and sqrt impl (#5329) (#5565)
## Description simple changes that uses newton's method for sqrt and decomposition to `u64` for `log2` - `log` builds up on `log2` for `u256` This should fix #5329 Ping @SwayStar123 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Configuration menu - View commit details
-
Copy full SHA for 1a32c21 - Browse repository at this point
Copy the full SHA 1a32c21View commit details -
Fixes issue of missing type annotations on explicit returns. (#5575)
## Description Explicit returns did not have any type annotation causing the method disambiguation to fail. The solution was to add a new field to the `TypeCheckContext` called `function_type_annotation`. This field is initialized only in the type_check of function declarations. The field is used to set the type_annotation one while doing the type check of explicit return expressions. With this change `TypeCheckUnification` was also simplified as the unification is now done with `function_type_annotation`. The result was a few functions that are no longer required to be removed. Closes #5518 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: João Matos <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 60a359c - Browse repository at this point
Copy the full SHA 60a359cView commit details -
Remove
DeRef
andDeRefMut
implementations in thenamespace
modu……le (#5577) ## Description This PR is the first step of a large refactoring of the `namespace` module. The PR removes the `DeRef` and `DeRefMut` implementations in the `namespace` module, as they make refactoring more difficult to keep track of. This change means that calls to `Root` and `Module` must now explicitly go through `Namespace`, since that is the type that is passed along during typechecking. I'm submitting the PR now because there have been changes to `master` while I've been working on this, and the changes are really difficult to merge, so I want `master` to be relatively stable. Subsequent PRs will: - Eliminate the `dst` parameter from all import functions (the destination is always the current module). - Move all import functions to `Namespace` (they currently reside in `Module` where they aren't needed, and where they require a clone the module path to work). - Move `Namespace::init` to `Root`, and change how it is used (it currently holds a constant declaration of `CONTRACT_ID` for contract modules, and that declaration is cloned into every submodule. The nice way to do this is to declare it in the root module and implicitly import it into each submodule). - Eliminate the `Option` part of `Module::name` (modules are not allowed to be nameless - the option only exists because they root module can in principle be nameless, but it ought to be named based on the package the module structure is in). - Fix the import and name resolution functions so that they don't treat absolute paths as relative (this should fix some of the performance issues we're seeing). - Make `Namespace::root` a reference so that the entire module structure isn't cloned for every submodule (this requires a change in ownership of the root module). - Introduce reexports in the form of `pub use`. This PR is the first step in fixing #5498. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Configuration menu - View commit details
-
Copy full SHA for 37b4e6e - Browse repository at this point
Copy the full SHA 37b4e6eView commit details -
Implements Iterator trait and for loops. (#5557)
## Description This implements an Iterator trait in std-lib, and adds iter() to Vec. This also adds parsing and desugaring of for loops. ``` for pattern in iterator { code_block } ``` is desugared into: ``` let mut iterable = iterator; while true { let value_opt = iterable.next(); if value_opt.is_none() { break; } let value = value_opt.unwrap(); code_block } ``` This also adds for loops documentation to the control flow docs. We still have to fix this issues: - #5567 - #5568 - #5570 - #5571 Closes #145 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Configuration menu - View commit details
-
Copy full SHA for 2f605d5 - Browse repository at this point
Copy the full SHA 2f605d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 211ee91 - Browse repository at this point
Copy the full SHA 211ee91View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf621fa - Browse repository at this point
Copy the full SHA bf621faView commit details -
Configuration menu - View commit details
-
Copy full SHA for a860ad4 - Browse repository at this point
Copy the full SHA a860ad4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4631726 - Browse repository at this point
Copy the full SHA 4631726View commit details -
Configuration menu - View commit details
-
Copy full SHA for f452338 - Browse repository at this point
Copy the full SHA f452338View commit details -
Configuration menu - View commit details
-
Copy full SHA for b79728f - Browse repository at this point
Copy the full SHA b79728fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06826e5 - Browse repository at this point
Copy the full SHA 06826e5View commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 422fd59 - Browse repository at this point
Copy the full SHA 422fd59View commit details
Commits on Feb 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b8ddfe1 - Browse repository at this point
Copy the full SHA b8ddfe1View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bcd5f8f - Browse repository at this point
Copy the full SHA bcd5f8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4906bbf - Browse repository at this point
Copy the full SHA 4906bbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce9ebd - Browse repository at this point
Copy the full SHA 9ce9ebdView commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 924deee - Browse repository at this point
Copy the full SHA 924deeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7100002 - Browse repository at this point
Copy the full SHA 7100002View commit details -
Configuration menu - View commit details
-
Copy full SHA for 397d537 - Browse repository at this point
Copy the full SHA 397d537View commit details -
Configuration menu - View commit details
-
Copy full SHA for 287c5d6 - Browse repository at this point
Copy the full SHA 287c5d6View commit details
Commits on Feb 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 40c5a60 - Browse repository at this point
Copy the full SHA 40c5a60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22e7269 - Browse repository at this point
Copy the full SHA 22e7269View commit details