Fix build-mdbook CI failure #5574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
approved these changes
Feb 7, 2024
sdankel
added a commit
that referenced
this pull request
Feb 8, 2024
## Description `build-mdbook` was failing on multiple PRs with ``` Run cargo install --locked --debug --path ./forc error: binary `forc` already exists in destination Add --force to overwrite ``` https://github.com/FuelLabs/sway/actions/runs/7819113568/attempts/1?pr=5569 https://github.com/FuelLabs/sway/actions/runs/7816891674/job/21336246772?pr=5565 `cargo install` keeps track of which binaries it has installed in ~/.cargo/crates.toml and ~/.cargo.crates2.json. By using the entire cached `cargo` directory, cargo is able to tell that it has previously installed the binaries and install correctly. ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
build-mdbookwas failing on multiple PRs withhttps://github.com/FuelLabs/sway/actions/runs/7819113568/attempts/1?pr=5569
https://github.com/FuelLabs/sway/actions/runs/7816891674/job/21336246772?pr=5565
cargo installkeeps track of which binaries it has installed in ~/.cargo/crates.toml and ~/.cargo.crates2.json. By using the entire cachedcargodirectory, cargo is able to tell that it has previously installed the binaries and install correctly.Checklist
Breaking*orNew Featurelabels where relevant.