Forbid configurables in constants #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
added
the
breaking
IGI-111
force-pushed
the
IGI-111/configurable-consts
branch
2 times, most recently
from
0f01347
to
c8e78dc
Compare
IGI-111
force-pushed
the
IGI-111/configurable-consts
branch
from
c8e78dc
to
6d20505
Compare
JoshuaBatty
approved these changes
Jan 20, 2024
tritao
approved these changes
Jan 20, 2024
sdankel
pushed a commit
that referenced
this pull request
Jan 24, 2024
## Description Don't allow configurables to be used in const expressions except as storage and configurable initializers. Fix #5272 Fix #5261 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: João Matos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't allow configurables to be used in const expressions except as
storage and configurable initializers.
Fix #5272
Fix #5261
Checklist
Breaking*orNew Featurelabels where relevant.