Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement For Loops and Iterators #145

Closed
sezna opened this issue Aug 18, 2021 · 0 comments · Fixed by #5557
Closed

Implement For Loops and Iterators #145

sezna opened this issue Aug 18, 2021 · 0 comments · Fixed by #5557
Assignees
Labels
big this task is hard and will take a while compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request language feature Core language features visible to end users P: low
Milestone

Comments

@sezna
Copy link
Contributor

sezna commented Aug 18, 2021

We have while loops but not for loops. This is blocked by a standard library implementation of iterators (#144), which can be easily generated via range syntax like in Rust. (0..10).

@adlerjohn adlerjohn added the compiler General compiler. Should eventually become more specific as the issue is triaged label Aug 23, 2021
@sezna sezna added the big this task is hard and will take a while label Sep 22, 2021
@adlerjohn adlerjohn moved this to Todo in Fuel Network Jan 7, 2022
@adlerjohn adlerjohn added the enhancement New feature or request label Jan 7, 2022
@mohammadfawaz mohammadfawaz added the language feature Core language features visible to end users label Mar 15, 2022
@IGI-111 IGI-111 added this to the October 2023 milestone Jul 6, 2023
@IGI-111 IGI-111 modified the milestones: 0, swayfmt Aug 21, 2023
@esdrubal esdrubal self-assigned this Feb 6, 2024
@esdrubal esdrubal moved this from Todo to Review in Fuel Network Feb 6, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Fuel Network Feb 8, 2024
sdankel pushed a commit that referenced this issue Feb 8, 2024
## Description

This implements an Iterator trait in std-lib, and adds iter() to Vec.
This also adds parsing and desugaring of for loops.

```
    for pattern in iterator {
        code_block
    }
```
 is desugared into:
```
    let mut iterable = iterator;
    while true {
        let value_opt = iterable.next();
        if value_opt.is_none() {
             break;
        }
        let value = value_opt.unwrap();
        code_block
    }
```

This also adds for loops documentation to the control flow docs.

We still have to fix this issues:
 -  #5567
 -  #5568
 -  #5570
 -  #5571

Closes #145

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big this task is hard and will take a while compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request language feature Core language features visible to end users P: low
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants