Polish admins-only policy room feature #21950

rezkiy37 · 2023-06-30T12:22:51Z

Details

Fixed Issues

$ #21456
PROPOSAL: #21456 (comment)

Tests

Verify that no errors appear in the JS console

Add the “Who can post” setting to the “New Room” form.
a. Since, it is not a production feature yet, you should be invited to the policy room beta.
b. Run script "web" and open the web app. Obviously, you are able to run on any platform, but here we can easily debug.
c. Click on "+" (FAB menu).
d. Click on "New room".
e. Select a workspace, where you are an admin.
f. Verify that there is a new selector - "Who can post" with 2 values: "All members" and "Amins only".
g. Fill in all selectors/inputs as you want (up to you).
h. Open the "Network" tap of DevTools. Recommendations: select "XHR/Fetch" and "Preserve Log".
i. Click on "Create room".
j. Find a request ends "command=AddWorksapceRoom" and open "Payload" tap.
k. Verify that there is the writeCapability key and the value should be that you have selected: "All members" equals all and "Amins only" equals admins.
l. Repeat from the c step, but select the other value for the new selector.
Filter out admin-only rooms for members in the “Share somewhere” selector of the “Assign task” action (accessible via the FAB menu) - so that members cannot share a task to the room.
a. Since, it is not a production feature yet, you should be invited to the policy room beta and assign task beta.
b. Run script "web" and open the web app. Obviously, you are able to run on any platform, but here we can easily debug.
c. You should be a member of any workspace where there are "admin-only" and "all members" posting rooms. Note: you should not be an admin for this workspace to test this improvement.
d. Click on "+" (FAB menu).
f. Click on "Assign task".
f. Fill in any text to "Title" and "Description", it is up to you.
g. Click on "Next".
h. Click on "Assign".
i. Verify that no "admin-only" rooms, because your are a member for the current workspace.
Reduce the padding between the last message and the bottom of the page when Composer isn’t present (e.g. for the “member” view in an admin-only room).
a. Since, it is not a production feature yet, you should be invited to the policy room beta.
b. Run script "web" and open the web app. Obviously, you are able to run on any platform, but here we can easily debug.
c. You should be a member of any workspace where there are "admin-only" and "all members" posting rooms. Note: you should not be an admin for this workspace to test this improvement.
d. Open any "admin-only" posting room.
e. Verify that the distance between the bottom and the last message is shorter than on the staging or production.
Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for "admin-only" rooms.
a. Since, it is not a production feature yet, you should be invited to the policy room beta.
b. Run script "web" and open the web app. Obviously, you are able to run on any platform, but here we can easily debug.
c. Open any "admin-only" posting room.
d. Verify that the welcome message is a kind of: "Use <ROOM_NAME> to hear about important announcements related to <WORKSPACE_NAME>".

Offline tests

Add the “Who can post” setting to the “New Room” form.
a. Since, it is not a production feature yet, you should be invited to the policy room beta.
b. Open the app.
c. Enable the offline mode.
d. Click on "+" (FAB menu).
e. Click on "New room".
f. Select a workspace, where you are an admin.
g. Verify that a new selector appears - "Who can post" with 2 values: "All members" and "Amins only".
h. Select any value for the new selector. Fill in the other selectors/inputs as you want (up to you).
i. Click on "Create room".
j. The app should redirect you to a new room chat page.
k. Open the chat settings and verify that it has the same values that you entered before.
l. Disable the offline mode.
m. Repeat from the c step, but select the other value for the new selector.

QA Steps

Verify that no errors appear in the JS console

Add the “Who can post” setting to the “New Room” form.
a. Since, it is not a production feature yet, you should be invited to the policy room beta.
b. Open the app.
c. Click on "+" (FAB menu).
d. Click on "New room".
e. Select a workspace, where you are an admin.
f. Verify that a new selector appears - "Who can post" with 2 values: "All members" and "Amins only".
g. Select any value for the new selector. Fill in the other selectors/inputs as you want (up to you).
h. Click on "Create room".
i. The app should redirect you to a new room chat page.
j. Open the chat settings and verify that it has the same values that you entered before.
k. Repeat from the c step, but select the other value for the new selector.
Filter out admin-only rooms for members in the “Share somewhere” selector of the “Assign task” action (accessible via the FAB menu) - so that members cannot share a task to the room.
a. Since, it is not a production feature yet, you should be invited to the policy room beta and assign task beta.
b. Open the app.
c. You should be a member of any workspace where there are "admin-only" and "all members" posting rooms. Note: you should not be an admin for this workspace to test this improvement.
d. Click on "+" (FAB menu).
f. Click on "Assign task".
f. Fill in any text to "Title" and "Description", it is up to you.
g. Click on "Next".
h. Click on "Assign".
i. Verify that no "admin-only" rooms, because your are a member for the current workspace.
Reduce the padding between the last message and the bottom of the page when Composer isn’t present (e.g. for the “member” view in an admin-only room).
a. Since, it is not a production feature yet, you should be invited to the policy room beta.
b. Open the app.
c. You should be a member of any workspace where there are "admin-only" and "all members" posting rooms. Note: you should not be an admin for this workspace to test this improvement.
d. Open any "admin-only" posting room.
e. Verify that the distance between the bottom and the last message is shorter than on the staging or production.
Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for "admin-only" rooms.
a. Since, it is not a production feature yet, you should be invited to the policy room beta.
b. Open the app.
c. Open any "admin-only" posting room.
d. Verify that the welcome message is a kind of: "Use <ROOM_NAME> to hear about important announcements related to <WORKSPACE_NAME>".

PR Author Checklist

Screenshots/Videos

Web

Add the “Who can post” setting to the “New Room” form.

1.mov

Filter out admin-only rooms for members in the “Share somewhere” selector of the “Assign task” action (accessible via the FAB menu) - so that members cannot share a task to the room.

2.mp4

Reduce the padding between the last message and the bottom of the page when Composer isn’t present (e.g. for the “member” view in an admin-only room).

Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for "admin-only" rooms.

Mobile Web - Chrome

Add the “Who can post” setting to the “New Room” form.

Chrome.1.MP4

Filter out admin-only rooms for members in the “Share somewhere” selector of the “Assign task” action (accessible via the FAB menu) - so that members cannot share a task to the room.

Chrome.2.MP4

Reduce the padding between the last message and the bottom of the page when Composer isn’t present (e.g. for the “member” view in an admin-only room).

Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for "admin-only" rooms.

Mobile Web - Safari

Add the “Who can post” setting to the “New Room” form.

Mobile.Safari.1.MP4

Filter out admin-only rooms for members in the “Share somewhere” selector of the “Assign task” action (accessible via the FAB menu) - so that members cannot share a task to the room.

Mobile.Safari.2.MP4

Reduce the padding between the last message and the bottom of the page when Composer isn’t present (e.g. for the “member” view in an admin-only room).

Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for "admin-only" rooms.

Desktop

Add the “Who can post” setting to the “New Room” form.

Deskop.1.mov

Filter out admin-only rooms for members in the “Share somewhere” selector of the “Assign task” action (accessible via the FAB menu) - so that members cannot share a task to the room.

Deskop.2.mov

Reduce the padding between the last message and the bottom of the page when Composer isn’t present (e.g. for the “member” view in an admin-only room).

Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for "admin-only" rooms.

iOS

Add the “Who can post” setting to the “New Room” form.

IOS.1.mov

Filter out admin-only rooms for members in the “Share somewhere” selector of the “Assign task” action (accessible via the FAB menu) - so that members cannot share a task to the room.

IOS.2.mov

Reduce the padding between the last message and the bottom of the page when Composer isn’t present (e.g. for the “member” view in an admin-only room).

Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for "admin-only" rooms.

Android

Add the “Who can post” setting to the “New Room” form.

Android.1.mov

Filter out admin-only rooms for members in the “Share somewhere” selector of the “Assign task” action (accessible via the FAB menu) - so that members cannot share a task to the room.

Android.2.mov

Reduce the padding between the last message and the bottom of the page when Composer isn’t present (e.g. for the “member” view in an admin-only room).

Update the room description to be Use ${roomName} to hear about important announcements related to ${workspaceName} for "admin-only" rooms.

This reverts commit 823d28a.

…ture/21456-polish-admin-rooms

src/pages/workspace/WorkspaceNewRoomPage.js

…ture/21456-polish-admin-rooms

melvin-bot · 2023-07-04T09:45:05Z

@shawnborton @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2023-07-05T13:54:22Z

Seems good to me. One thing to consider though for a different PR, do we want all of the inputs on the create room flow to use our push-to-page pattern? cc @JmillsExpensify @trjExpensify for a gut check there

rezkiy37 · 2023-07-06T17:21:49Z

@shawnborton Hi! Do I need an approve from you on this PR?

shawnborton · 2023-07-06T17:23:27Z

This looks good to me, assuming we'll update the input style in a different PR.

…ture/21456-polish-admin-rooms

amyevans · 2023-07-24T15:02:23Z

@rezkiy37 there are conflicts now 😅

…ture/21456-polish-admin-rooms

rezkiy37 · 2023-07-24T15:05:20Z

@rezkiy37 there are conflicts now 😅

Just fixed!

mananjadhav · 2023-07-24T16:39:49Z

@amyevans I did some testing and it works fine. Can you do a final review? I can then finish the checklist by uploading screencasts for all the platforms?

amyevans · 2023-07-24T17:51:45Z

@mananjadhav Done!

mananjadhav · 2023-07-25T06:10:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-policy-admin_UJauJnF3.mp4

Mobile Web - Chrome

mweb-chrome-policy-admin.mov

Mobile Web - Safari

mweb-safari-policy-admin.mov

Desktop

desktop-policy-admin.mov

iOS

ios-policy-admin.mov

Android

android-policy-admin.mov

mananjadhav · 2023-07-25T08:09:12Z

@amyevans All yours.

🎀 👀 🎀 C+ reviewed.

cc - @rezkiy37

OSBotify · 2023-07-25T13:47:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-26T16:10:40Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.46-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-27T22:08:46Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-27T22:39:26Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.46-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Pujan92 · 2023-07-28T12:20:22Z

@rezkiy37 @mananjadhav @amyevans due to incorrect mappings in buildOptimisticChatReport for missed instances within this PR causing regressions.

rezkiy37 · 2023-07-28T12:53:57Z

@rezkiy37 @mananjadhav @amyevans due to incorrect mappings in buildOptimisticChatReport for missed instances within this PR causing regressions.

@Pujan92, AFAIK, you already posted a proposal to fix it. Are you going to open a PR or should I do it?

Pujan92 · 2023-07-28T12:59:35Z

I can raise a PR but as it is in the regression period the author gets the first chance to raise it.

rezkiy37 · 2023-07-28T13:00:45Z

I can raise a PR but as it is in the regression period the author gets the first chance to raise it.

Well, I am the author and will fix it. Okay?

Pujan92 · 2023-07-28T13:04:35Z

Well, I am the author and will fix it. Okay?

Sure 😅 , if it is considered and labeled as deployBlocker then maybe the team could have considered my proposal and assigned me to unblock deployment.

OSBotify · 2023-07-31T18:37:15Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rezkiy37 added 16 commits June 27, 2023 13:19

add writeCapability to create new room

b8198c8

update admin room welcome message

823d28a

filter out admin-only rooms for members

43a46cc

Revert "update admin room welcome message"

8135994

This reverts commit 823d28a.

update admin room welcome message

a937311

fix reports visibility

42e21d7

remove extra space for offline indicator

3cacb87

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

e7e9cae

…ture/21456-polish-admin-rooms

omit padding bottom of ReportActionItemCreated

fc6d024

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

b298dea

…ture/21456-polish-admin-rooms

Apply destructuring assignment of values of validate method

e40d85c

Add JSDoc

e16e167

Add dummy translation

35807e8

Add real translations

e526c7e

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

78e9c5b

…ture/21456-polish-admin-rooms

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

5ad14aa

…ture/21456-polish-admin-rooms

burczu reviewed Jul 4, 2023

View reviewed changes

src/pages/workspace/WorkspaceNewRoomPage.js Outdated Show resolved Hide resolved

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

5e0e492

…ture/21456-polish-admin-rooms

rezkiy37 marked this pull request as ready for review July 4, 2023 09:45

rezkiy37 requested a review from a team as a code owner July 4, 2023 09:45

melvin-bot bot requested review from mananjadhav and shawnborton and removed request for a team July 4, 2023 09:45

rezkiy37 mentioned this pull request Jul 4, 2023

[HOLD for payment 2023-08-14] [HOLD for payment 2023-08-08] [HOLD for payment 2023-08-03] [$1000] Polish admins-only policy room feature #21456

Closed

4 tasks

rezkiy37 requested a review from burczu July 5, 2023 12:06

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

ae5b9dd

…ture/21456-polish-admin-rooms

add a comment

38659cb

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

b886d07

…ture/21456-polish-admin-rooms

amyevans approved these changes Jul 24, 2023

View reviewed changes

amyevans merged commit 0e2f742 into Expensify:main Jul 25, 2023

Pujan92 mentioned this pull request Jul 26, 2023

[$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace #23638

Closed

6 tasks

s-alves10 mentioned this pull request Jul 26, 2023

Dev: Web - The message "This is the beginning of your chat" is displayed for a while when opening the requested money detail #23647

Closed

6 tasks

OSBotify mentioned this pull request Jul 26, 2023

Deploy Checklist: New Expensify 2023-07-26 #23657

Closed

43 tasks

OSBotify mentioned this pull request Jul 27, 2023

Deploy Checklist: New Expensify 2023-07-27 #23765

Closed

79 tasks

dukenv0307 mentioned this pull request Jul 28, 2023

[HOLD for payment 2023-08-08][$1000] Dev: Web - Thread report header displays no data & composer is hidden when clicking 'Reply in thread' icon while in offline mode #23646

Closed

6 tasks

rezkiy37 mentioned this pull request Jul 28, 2023

Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815

Merged

58 tasks

bernhardoj mentioned this pull request Jul 29, 2023

[$1000] Web - Optimistic expense request page is broken #23847

Closed

6 tasks

This was referenced Jul 31, 2023

[$1000] Dev - Console log error displayed on clicking 'Select a workspace' dropdown value #23818

Closed

Fix/23818 - Polish admins-only policy room - Clear "Form's" states correctly #23919

Merged

uafrontender mentioned this pull request Aug 1, 2023

[Awaiting checklist completion] [$1000] Composer top padding collapsed in room after scroll up #22389

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Polish admins-only policy room feature #21950

Polish admins-only policy room feature #21950

rezkiy37 commented Jun 30, 2023 •

edited

Loading

melvin-bot bot commented Jul 4, 2023

shawnborton commented Jul 5, 2023

rezkiy37 commented Jul 6, 2023

shawnborton commented Jul 6, 2023

amyevans commented Jul 24, 2023

rezkiy37 commented Jul 24, 2023 •

edited

Loading

mananjadhav commented Jul 24, 2023

amyevans commented Jul 24, 2023

mananjadhav commented Jul 25, 2023 •

edited

Loading

mananjadhav commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

Pujan92 commented Jul 28, 2023 •

edited

Loading

rezkiy37 commented Jul 28, 2023

Pujan92 commented Jul 28, 2023

rezkiy37 commented Jul 28, 2023

Pujan92 commented Jul 28, 2023

OSBotify commented Jul 31, 2023

Polish admins-only policy room feature #21950

Polish admins-only policy room feature #21950

Conversation

rezkiy37 commented Jun 30, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 4, 2023

shawnborton commented Jul 5, 2023

rezkiy37 commented Jul 6, 2023

shawnborton commented Jul 6, 2023

amyevans commented Jul 24, 2023

rezkiy37 commented Jul 24, 2023 • edited Loading

mananjadhav commented Jul 24, 2023

amyevans commented Jul 24, 2023

mananjadhav commented Jul 25, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mananjadhav commented Jul 25, 2023

OSBotify commented Jul 25, 2023

OSBotify commented Jul 26, 2023

OSBotify commented Jul 27, 2023

OSBotify commented Jul 27, 2023

Pujan92 commented Jul 28, 2023 • edited Loading

rezkiy37 commented Jul 28, 2023

Pujan92 commented Jul 28, 2023

rezkiy37 commented Jul 28, 2023

Pujan92 commented Jul 28, 2023

OSBotify commented Jul 31, 2023

rezkiy37 commented Jun 30, 2023 •

edited

Loading

rezkiy37 commented Jul 24, 2023 •

edited

Loading

mananjadhav commented Jul 25, 2023 •

edited

Loading

Pujan92 commented Jul 28, 2023 •

edited

Loading