-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish admins-only policy room feature #21950
Merged
amyevans
merged 39 commits into
Expensify:main
from
rezkiy37:feature/21456-polish-admin-rooms
Jul 25, 2023
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
b8198c8
add writeCapability to create new room
rezkiy37 823d28a
update admin room welcome message
rezkiy37 43a46cc
filter out admin-only rooms for members
rezkiy37 8135994
Revert "update admin room welcome message"
rezkiy37 a937311
update admin room welcome message
rezkiy37 42e21d7
fix reports visibility
rezkiy37 3cacb87
remove extra space for offline indicator
rezkiy37 e7e9cae
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 fc6d024
omit padding bottom of ReportActionItemCreated
rezkiy37 b298dea
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 e40d85c
Apply destructuring assignment of values of validate method
rezkiy37 e16e167
Add JSDoc
rezkiy37 35807e8
Add dummy translation
rezkiy37 e526c7e
Add real translations
rezkiy37 78e9c5b
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 5ad14aa
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 5e0e492
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 ae5b9dd
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 e8d2625
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 2865c7f
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 36f9d56
restrict some actions
rezkiy37 f4c89d9
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 3c91515
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 c6279a9
Revert "restrict some actions"
rezkiy37 9654e73
Revert "remove extra space for offline indicator"
rezkiy37 8b7fe70
Revert "fix reports visibility"
rezkiy37 fbbf0b7
Revert "filter out admin-only rooms for members"
rezkiy37 c1f8509
one-line of isAdminsOnlyPostingRoom
rezkiy37 3b23219
revert redundant changes
rezkiy37 9e8e423
show write capability picker for admins only
rezkiy37 3b3f3c9
move down write capability picker
rezkiy37 e69102f
Revert "omit padding bottom of ReportActionItemCreated"
rezkiy37 50a6315
remove bottom spacing of messages list when no composer
rezkiy37 d1a792c
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 8a224fc
omit unmounted inputs of form
rezkiy37 ccc00ba
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 76ba533
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 38659cb
add a comment
rezkiy37 b886d07
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to add a comment for what we're doing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, will add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - 38659cb