[$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace #23638

kbecciv · 2023-07-26T12:39:30Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Click on FAB icon
Create a new workspace and check the console

Expected Result:

Should not show any console error

Actual Result:

Console error appears (Invalid prop reports.report_5370990936798009.writeCapability of value daily supplied to ReportScreenWrapper, expected one of ["all","admins"].
)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev 1.3.45-8
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-26.at.12.54.33.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690356298944369

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01db31db71b4efd7d9
Upwork Job ID: 1688916131373895680
Last Price Increase: 2023-08-08

The text was updated successfully, but these errors were encountered:

melvin-bot · 2023-07-26T12:39:34Z

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-26T12:39:37Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

dukenv0307 · 2023-07-26T12:50:36Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Console error on create new workspace

What is the root cause of that problem?

We are missing writeCapability param when we call buildOptimisticChatReport here which makes CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY becomes writeCapability param and that is an invalid value for writeCapability and then console error appear

App/src/libs/ReportUtils.js

Lines 2001 to 2013 in 1fac96b

    
           function buildOptimisticWorkspaceChats(policyID, policyName) { 
        
               const announceChatData = buildOptimisticChatReport( 
        
                   [currentUserAccountID], 
        
                   CONST.REPORT.WORKSPACE_CHAT_ROOMS.ANNOUNCE, 
        
                   CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE, 
        
                   policyID, 
        
                   CONST.POLICY.OWNER_ACCOUNT_ID_FAKE, 
        
                   false, 
        
                   policyName, 
        
                   null, 
        
                   // #announce contains all policy members so notifying always should be opt-in only. 
        
                   CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,

What changes do you think we should make in order to solve the problem?

We should add writeCapability param as CONST.REPORT.WRITE_CAPABILITIES.ALL before this line

...
CONST.REPORT.WRITE_CAPABILITIES.ALL,
CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,

App/src/libs/ReportUtils.js

Line 2013 in 1fac96b

CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY,

What alternative solutions did you explore? (Optional)

Pujan92 · 2023-07-26T13:14:39Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error for new workspace, request money action & child report navigation

What is the root cause of that problem?

It is a regression from PR #21950 where we have added an extra param writeCapability for the function buildOptimisticChatReport but not passed from all required buildOptimisticChatReport called occurrences.

https://github.com/Expensify/App/pull/21950/files#diff-65c096044d5f69b35bcdec14c99c4fda4580759df9b1a7c36650d58eea276f1dR1763

App/src/libs/ReportUtils.js

Lines 2002 to 2014 in 1fac96b

    
           const announceChatData = buildOptimisticChatReport( 
        
               [currentUserAccountID], 
        
               CONST.REPORT.WORKSPACE_CHAT_ROOMS.ANNOUNCE, 
        
               CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE, 
        
               policyID, 
        
               CONST.POLICY.OWNER_ACCOUNT_ID_FAKE, 
        
               false, 
        
               policyName, 
        
               null, 
        
               // #announce contains all policy members so notifying always should be opt-in only. 
        
               CONST.REPORT.NOTIFICATION_PREFERENCE.DAILY, 
        
           );

App/src/components/ReportActionItem/MoneyRequestAction.js

Lines 100 to 115 in 1fac96b

    
           const thread = ReportUtils.buildOptimisticChatReport( 
        
               participantAccountIDs, 
        
               props.translate(ReportActionsUtils.isSentMoneyReportAction(props.action) ? 'iou.threadSentMoneyReportName' : 'iou.threadRequestReportName', { 
        
                   formattedAmount: ReportActionsUtils.getFormattedAmount(props.action), 
        
                   comment: props.action.originalMessage.comment, 
        
               }), 
        
               '', 
        
               CONST.POLICY.OWNER_EMAIL_FAKE, 
        
               CONST.POLICY.OWNER_ACCOUNT_ID_FAKE, 
        
               false, 
        
               '', 
        
               undefined, 
        
               CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS, 
        
               props.action.reportActionID, 
        
               props.requestReportID, 
        
           );

App/src/libs/actions/Report.js

Lines 581 to 593 in 3d22f59

    
           const newChat = ReportUtils.buildOptimisticChatReport( 
        
               participantAccountIDs, 
        
               lodashGet(parentReportAction, ['message', 0, 'text']), 
        
               lodashGet(parentReport, 'chatType', ''), 
        
               lodashGet(parentReport, 'policyID', CONST.POLICY.OWNER_EMAIL_FAKE), 
        
               CONST.POLICY.OWNER_ACCOUNT_ID_FAKE, 
        
               false, 
        
               '', 
        
               undefined, 
        
               CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS, 
        
               parentReportAction.reportActionID, 
        
               parentReportID, 
        
           );

What changes do you think we should make in order to solve the problem?

We need to pass writeCapability param with the correct value in all 3 places.

rezkiy37 · 2023-07-28T13:33:41Z

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue, because I am the author of the broken PR.

amyevans · 2023-07-28T14:00:26Z

Self-assigning since this is a regression from #21456

laurenreidexpensify · 2023-07-28T15:06:06Z

@amyevans can we remove needs reproduction label then, as am assuming you can repro?

amyevans · 2023-07-28T15:18:34Z

Good call, done!

ayazhussain79 · 2023-07-28T16:02:26Z

@amyevans can you please check that I have reported this #23647 bug before this #23638 one
@Pujan92 mentioned they have same RCA

ayazhussain79 · 2023-07-31T13:22:51Z

@amyevans @rezkiy37 please check that here is the root case of this issue #23647 that i have reported before PR deployed on staging and i have reported before this bug #23638

rezkiy37 · 2023-07-31T13:39:20Z

@amyevans @rezkiy37 please check that here is the root case of this issue #23647 that i have reported before PR deployed on staging and i have reported before this bug #23638

The root case is same. I fixed it here - #23815.

ayazhussain79 · 2023-07-31T13:46:21Z

@rezkiy37 yes it's fixed but i have reported this bug #23647 before this one #23638 you can check that on slack

rezkiy37 · 2023-07-31T13:48:04Z

@rezkiy37 yes it's fixed but i have reported this bug #23647 before this one #23638

Sorry, but I am a person who process such kind of questions. I am not an Expensify employee, I work at Callstack.

ayazhussain79 · 2023-08-02T13:12:55Z

@amyevans @laurenreidexpensify can you please that again #23638 (comment)

melvin-bot · 2023-08-08T14:12:41Z

Job added to Upwork: https://www.upwork.com/jobs/~01db31db71b4efd7d9

melvin-bot · 2023-08-08T14:12:45Z

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-08T14:12:50Z

Current assignee @mananjadhav is eligible for the External assigner, not assigning anyone new.

laurenreidexpensify · 2023-08-08T14:18:38Z

Payment Preparation Summary:

Bug reporter: @gadhiyamanan - $250, offer sent in Upwork AND @ayazhussain79 - $250, offer sent in Upwork
Contributor: @rezkiy37 - no payment, CallStack employee
C+: @mananjadhav - $1000 for review, can request payment in newdot

gadhiyamanan · 2023-08-08T14:19:48Z

@laurenreidexpensify offer accepted, thanks

ayazhussain79 · 2023-08-08T14:24:17Z

@laurenreidexpensify offer accepted, Thank you

mananjadhav · 2023-08-08T14:27:18Z

@laurenreidexpensify there is no payment for me, this was a regression. Payment will be handled in the policy-admin issue.

laurenreidexpensify · 2023-08-08T14:28:01Z

Payment Summary:

Bug reporter: @gadhiyamanan - $250, offer sent in Upwork AND @ayazhussain79 - $250, offer sent in Upwork
Contributor: @rezkiy37 - no payment, CallStack employee
C+: @mananjadhav -no payment as this was a regression

laurenreidexpensify · 2023-08-08T14:28:33Z

Closing out as the regression testing will be handled in the original issue

kbecciv added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 26, 2023

melvin-bot bot assigned laurenreidexpensify Jul 26, 2023

rezkiy37 mentioned this issue Jul 28, 2023

Polish admins-only policy room feature #21950

Merged

57 tasks

melvin-bot bot added the Overdue label Jul 28, 2023

amyevans assigned amyevans and rezkiy37 Jul 28, 2023

melvin-bot bot removed the Overdue label Jul 28, 2023

amyevans assigned mananjadhav Jul 28, 2023

amyevans removed the Needs Reproduction Reproducible steps needed label Jul 28, 2023

s-alves10 mentioned this issue Jul 28, 2023

[$1000] Reply in Thread page flickers when navigating from the message #23806

Closed

6 tasks

rezkiy37 mentioned this issue Jul 28, 2023

Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815

Merged

58 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 28, 2023

amyevans changed the title ~~Dev: Web - Console error on create new workspace~~ [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace Aug 7, 2023

amyevans added Reviewing Has a PR in review Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Aug 7, 2023

laurenreidexpensify added Daily KSv2 External Added to denote the issue can be worked on by a contributor and removed Weekly KSv2 labels Aug 8, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace~~ [$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace Aug 8, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 8, 2023

laurenreidexpensify removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Aug 8, 2023

laurenreidexpensify closed this as completed Aug 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace #23638

[$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace #23638

kbecciv commented Jul 26, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

dukenv0307 commented Jul 26, 2023 •

edited

Loading

Pujan92 commented Jul 26, 2023 •

edited

Loading

rezkiy37 commented Jul 28, 2023

amyevans commented Jul 28, 2023

laurenreidexpensify commented Jul 28, 2023

amyevans commented Jul 28, 2023

ayazhussain79 commented Jul 28, 2023

ayazhussain79 commented Jul 31, 2023

rezkiy37 commented Jul 31, 2023

ayazhussain79 commented Jul 31, 2023 •

edited

Loading

rezkiy37 commented Jul 31, 2023

ayazhussain79 commented Aug 2, 2023

melvin-bot bot commented Aug 8, 2023

melvin-bot bot commented Aug 8, 2023

melvin-bot bot commented Aug 8, 2023

laurenreidexpensify commented Aug 8, 2023

gadhiyamanan commented Aug 8, 2023

ayazhussain79 commented Aug 8, 2023

mananjadhav commented Aug 8, 2023

laurenreidexpensify commented Aug 8, 2023

laurenreidexpensify commented Aug 8, 2023

[$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace #23638

[$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace #23638

Comments

kbecciv commented Jul 26, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 26, 2023

melvin-bot bot commented Jul 26, 2023

Bug0 Triage Checklist (Main S/O)

dukenv0307 commented Jul 26, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Pujan92 commented Jul 26, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

rezkiy37 commented Jul 28, 2023

amyevans commented Jul 28, 2023

laurenreidexpensify commented Jul 28, 2023

amyevans commented Jul 28, 2023

ayazhussain79 commented Jul 28, 2023

ayazhussain79 commented Jul 31, 2023

rezkiy37 commented Jul 31, 2023

ayazhussain79 commented Jul 31, 2023 • edited Loading

rezkiy37 commented Jul 31, 2023

ayazhussain79 commented Aug 2, 2023

melvin-bot bot commented Aug 8, 2023

melvin-bot bot commented Aug 8, 2023

melvin-bot bot commented Aug 8, 2023

laurenreidexpensify commented Aug 8, 2023

gadhiyamanan commented Aug 8, 2023

ayazhussain79 commented Aug 8, 2023

mananjadhav commented Aug 8, 2023

laurenreidexpensify commented Aug 8, 2023

laurenreidexpensify commented Aug 8, 2023

kbecciv commented Jul 26, 2023 •

edited by melvin-bot bot

Loading

dukenv0307 commented Jul 26, 2023 •

edited

Loading

Pujan92 commented Jul 26, 2023 •

edited

Loading

ayazhussain79 commented Jul 31, 2023 •

edited

Loading