[HOLD for payment 2023-08-08][$1000] Dev: Web - Thread report header displays no data & composer is hidden when clicking 'Reply in thread' icon while in offline mode

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open an existing chat
2. Send message
3. Open dev tools & apply 'offline' network mode
4. Hover over the sent message & click on 'Reply in thread' icon

Expected Result:

Thread header should display the threaded message & 'from' link, and composer should be visible

Actual Result:

Thread header doesn't display the threaded message & 'from' link, and composer is not visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev 1.3.45-8
Reproducible in staging?: no
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-26.15-38-10.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690375363052749
https://expensify.slack.com/archives/C049HHMV9SM/p1690461910613649 (Similar bug)
View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0172d7253f196dfea5
• Upwork Job ID: 1684725080240574464
2023-07-28
• Automatic offers:
• Natnael-guchima | Reporter | 25809101

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[StevenKKC]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread report header displays no data & composer is hidden when clicking 'Reply in thread' icon while in offline mode.

What is the root cause of that problem?

When reply in thread while in offline mode, ReportUtils.buildOptimisticChatReport is called.

App/src/libs/actions/Report.js

Lines 581 to 593 in d68806f

	const newChat = ReportUtils.buildOptimisticChatReport(
	participantAccountIDs,
	lodashGet(parentReportAction, ['message', 0, 'text']),
	lodashGet(parentReport, 'chatType', ''),
	lodashGet(parentReport, 'policyID', CONST.POLICY.OWNER_EMAIL_FAKE),
	CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
	false,
	'',
	undefined,
	CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
	parentReportAction.reportActionID,
	parentReportID,
	);

We pass CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS to ReportUtils.buildOptimisticChatReport writeCapability parameter.
So report.writeCapability is set to always, but this value should be one of all, admins.

App/src/pages/reportPropTypes.js

Line 78 in d68806f

writeCapability: PropTypes.oneOf(_.values(CONST.REPORT.WRITE_CAPABILITIES)),

Therefore, the error is occured, and report is not fully displayed.

What changes do you think we should make in order to solve the problem?

We should pass proper value to ReportUtils.buildOptimisticChatReport as below.

    const newChat = ReportUtils.buildOptimisticChatReport(
        participantAccountIDs,
        lodashGet(parentReportAction, ['message', 0, 'text']),
        lodashGet(parentReport, 'chatType', ''),
        lodashGet(parentReport, 'policyID', CONST.POLICY.OWNER_EMAIL_FAKE),
        CONST.POLICY.OWNER_ACCOUNT_ID_FAKE,
        false,
        '',
        undefined,
+       CONST.REPORT.WRITE_CAPABILITIES.ALL,
        CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS,
        parentReportAction.reportActionID,
        parentReportID,
    );

What alternative solutions did you explore? (Optional)

None.

[zanyrenney]

I don't have a Dev environment, assigning eng to help with that step!

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[bondydaa]

hmm i don't understand, contributors don't have expensify vms either so I think what they mean is this is in main not on staging or production yet.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0172d7253f196dfea5

[melvin-bot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[dukenv0307]

I think this issue is a regression from this PR #21950

[Pujan92]

Seems 3 places we need to correct #23638 (comment)

[rezkiy37]

Hi, I’m Michael (Mykhailo) from Callstack and I would like to work in this issue, because I am the author of the broken PR.

[melvin-bot]

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @Natnael-Guchima 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[amyevans]

As @rezkiy37 mentioned this is a regression from #21456 so self-assigning

[Natnael-Guchima]

Accepted the offer. Thanks

[rezkiy37]

#23919 was merged. Is the issue going to be closed?

[amyevans]

Yeah I think we're okay to close. Typically we wait a week after deploy to prod before closing, but that's to handle payments, and I think since the bug reporter accepted the offer and no one else is due payment, we can close now.

[Natnael-Guchima]

@amyevans an offer was sent to me & it is not settled yet #23646 (comment)

[amyevans]

Okay my bad 😅, thanks for pointing it out. Reopening so that @zanyrenney can handle that part.

[Natnael-Guchima]

No worries 😁

[mananjadhav]

@zanyrenney Did you get a chance to look at this? Once @Natnael-Guchima is paid, we can close this one out.

[zanyrenney]

This is paid! Closing: