Deploy Checklist: New Expensify 2024-01-04

[github-actions]

Release Version: 1.4.22-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Allow assigning task to new accounts #29730
• Truncated money request preview #30240
• Fix/30654: Only allow admins to manually edit distance request amount and currency #31778
• Fix inconsistent workspace tooltip #32325
• [No QA] Standardize type-only imports #32475
• feat: add new input fields for tax tracking #32550
• Reintroduce receipt recovery skipping distance requests #32562
• Update MoneyRequestView.js to show Violations #32594
• fix: Handle merged account display name #32792
• fix/28562: text input in the Composer disappears #32799
• Fix/29901: Selected category should be in the list  #32902
• Display loading page for workspace page with section #32903
• [TS migration] Migrate 'WorkspaceInvoices' page to TypeScript #33152
• Workspace currency optimistic actions update #33171
• Add back animated status bar transition #33200
• [TS migration] Migrate 'PopoverMenu' component to TypeScript #33242
• [TS migration] Migrate 'CurrencySymbolButton.js' component to TypeScript #33243
• fix button icon style in light theme #33252
• Fix: Invite message does not remain #33269
• [TS migration] Migrate 'UserDetailsTooltip' component to TypeScript (after revert) #33275
• dismiss keyboard on Choose SSO or MagicCode page #33421
• [wave8] Ideal Nav Left Hand Panel Search #33499
• Android-Attachments-App crashes on uploading specific PDF #33561
• fix loading pdf failed #33586
• [TS migration] Migrate 'LocationErrorMessage' component to TypeScript #33597
• Ignore updates we already got #33666
• Upload photo icon remains white in light mode #33689
• Location text does not change on selecting Use current location #33726
• Go back home before navigating to Concierge #33744
• Show join button in the chat header #33791
• Fix form error inconsistencies on detecting HTML tag #33793
• fix: Codeblocks does not wrap. #33794
• Fix/33315: Add isDeletedParentAction field #33828
• fix: Browser back button takes to previous modal while modal back button closes it #33829
• [NoQA] Fix: Large Arguments Error by Changing File Transmission Method #33831
• [TS migration] Follow-up: add default props from modal to PopoverWith… #33835
• fix: delay in displaying comment length limit error #33848
• Remove error in optimistic data when editing task #33862
• Fix: Drop file here modal does not dismiss when file is no longer dragged over the area #33864
• [TS migration] Migrate 'ScreenWrapper' component to TypeScript #33870
• Fix: IOU - No error message when changing amount of a paid request  #33880
• fix: Create new rooms with notification: always #33924
• [NO QA] Fix consistent-type-imports lint warning #33943
• fix crash native request distance #33946
• [NoQA] Add line height style to the next steps #33957
• [CP Stg] Don't skip successData or failureData even if OnyxData from server is up-to-date #34006
• fix crash attachment #34030
• [CP Staging] Fix: Expense - App crashes when attempting to request money from a deleted workspace #34072
• Revert "Android-Attachments-App crashes on uploading specific PDF" #34078
• Revert "Fix composer is focused after opening another popover" #34089
• Add patch for boost dependency to fix React Native native builds #34119

Internal QA:

• Show "marked reimbursed" report actions in NewDot #33730 - @Beamanator

Deploy Blockers:

• Chat - Focus lost after choosing emoji from EmojPicker #33984
• [HOLD for payment 2024-01-17] Distance - 404 error appears in console after creating distance request #33985
• Web - Task - Console error when assining task to non-existent user with gmail #33989
• [$500] IOU - 'You marked this report...' message only appears on the second visit to IOU report #34003
• Expense - Expense preview with more than 1 request grays out when requesting money offline #34004
• [HOLD for payment 2024-01-17] Profile - Something went wrong error when trying to open a room/profile picture #34016
• [HOLD for payment 2024-01-17] Chat - App crashes after opening image preview and tapping back button #34017
• [HOLD for payment 2024-02-07] [$125] IOU - The selected category moves to the top of the list when <8 categories active #34018
• IOU - In scan request, tapping download file shows error pop up #34043
• [HOLD for payment 2024-02-07] [$500] Reimbursement - Reimbursement message is not copied with "Copy to clipboard" #34045
• [HOLD for payment 2024-01-17] [HOLD for payment 2024-01-18] Chat - The app crashes if I open an image attachment in offline mode #34047
• [$500] Distance - Receipt thumbnail is blank and is not clickable when request is made offline #34049
• [Hold for #34409] [$500] Android - Public room - Extra spacing above the room header #34050
• [$500] Expense - "This report will be reimbursed outside of Expensify" sentence disappears in thread #34051
• [HOLD for payment 2024-02-15] [$500] Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat #34052
• Reimbursement - Reimbursement message appears above Send money preview in report page #34053
• IOU - Tax settings for Foreign Currency Default are not applied #34055
• Tax - Selecting tax after refreshing tax rate redirects user to request page #34058
• [$500] [HOLD for payment 2024-01-17] Expense - App crashes when attempting to request money from a deleted workspace #34063

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.22-0 🚀

[jasperhuangg]

Checking off #34003 this appears to be a back-end issue.

[youssef-lr]

Demoting #34018

[kbecciv]

Regression is 1% left

#29730 failing #33986, repro in prod, Checking Off
#32562 - Validation pending
#32594 - Validation pending
#32792 - Validation pending
#32799 - Validation pending
#32902 failing #34018
#33242 - Validation pending
#33421 - Validation pending
#33730 - Validation pending
#33744 - Validation pending
#33791 - Validation pending
#33829 is blocked in Desktop with #25790 (comment), checking Off

Deploy Blockers:

#33984
#33985
#33989
#34004
#34016
#34017

[Beamanator]

testing #33730 myself, i meant to make it internal QA 😳

• Looking good! Also super small note: There's this follow-up to fix the case where special characters are not showing up perfectly in NewDot, and there's already a PR for it - so NAB

[blimpich]

Checked off #34050 as I don't think its a blocker.

[rlinoz]

Checking off #34053 as I don't think it is a blocker.

[kbecciv]

Regression is completed!

#29730 failing #33986, repro in prod, Checking Off
#32562 failing in Android app and Android/Chrome #34068, repro in Prod, checking Off
#32902 failing #34018
#33791 failing #34054, repro on prod, Checking Off

Blockers:
#33984
#33985
#33989
#34004
#34016
#34017
#34043
#34045
#34047
#34051
#34063
#34052
#34055
#34058

[amyevans]

Checked off #34058 as NAB

[marcaaron]

Checking off #33989. Does not seem related to any new changes and is not a serious problem AFAICT.

[marcaaron]

Checking off #34004 as it is the expected behavior.

[marcaaron]

Closed #34017 as it looks like a dupe.

[roryabraham]

#34006 was only CP'd on all platforms about an hour ago. I haven't looked closely at the deploy blockers, but I suspect that some of them may have been caused by that. Maybe it's worth it to just ask Applause to retest all of them and see which have been fixed?

[situchan]

#34006 was only CP'd on all platforms about an hour ago. I haven't looked closely at the deploy blockers, but I suspect that some of them may have been caused by that. Maybe it's worth it to just ask Applause to retest all of them and see which have been fixed?

#34039 has the same root cause but interesting that it was marked as reproducible in production

[marcaaron]

Sounds good @roryabraham. Not gonna deploy today so there's no rush.

[marcaaron]

Checking off #34063

[mvtglobally]

@roryabraham
Retests on the latest build 1.4.22-2

Chat - Focus lost after choosing emoji from EmojPicker #33984 - Still repro on build 1.4.22-2
Distance - 404 error appears in console after creating distance request #33985 - Still repro on build 1.4.22-2
Profile - Something went wrong error when trying to open a room/profile picture #34016 - Still repro on build 1.4.22-2
IOU - In scan request, tapping download file shows error pop up #34043 - Still repro on build 1.4.22-2
Chat - The app crashes if I open an image attachment in offline mode #34047 - Still repro on build 1.4.22-2
Expense - "This report will be reimbursed outside of Expensify" sentence disappears in thread #34051 - Still repro on build 1.4.22-2
Task - Task assigned to "Hidden" does not show "Hidden" as assignee in main chat #34052 - Still repro on build 1.4.22-2
IOU - Tax settings for Foreign Currency Default are not applied #34055 - Still repro on build 1.4.22-2

[thienlnam]

Marked off #33730 for #33730 (comment)

[kbecciv]

@thienlnam We verified PR #34030 on Web, mWeb and Desktop, the build is not ready for IOS and Android apps.

[thienlnam]

We're currently working on fixing the iOS and Android broken builds - I can manually QA the rest of these for the deploy

[thienlnam]

There's quite a few crashes this time from 1.4.17-7

com.google.mlkit.vision.face.internal.FaceRegistrar.getComponents
java.lang.NullPointerException - Attempt to invoke virtual method 'int java.util.AbstractCollection.size()' on a null object reference

MessageSchema.reflectField
java.lang.RuntimeException - Field packageName_ for wg.a not found. Known fields are [private int wg.a.A00, private java.lang.String wg.a.A01, priva

The user impact is limited, and I believe these are related to the issue we fixed here since these are all android crashes #34030

[thienlnam]