Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD - EApp #34466] [$500] Workspace - Infinite loading when navigate to workspace link without access #34039

Closed
4 of 6 tasks
lanitochka17 opened this issue Jan 5, 2024 · 22 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to Workspace link that doesn't have any users (https://staging.new.expensify.com/workspace/77336CD9870F8DB1
    )

Expected Result:

There's should be error indicating "You do not have access to this page. Are you trying to join the workspace? Please reach out to the owner of this workspace so they can add you as a member! Something else? Reach out to Concierge"

Actual Result:

Infinite loading remains when user navigate to workspace link without access

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333300_1704469547685.LYYL9830.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013aa8ecc43f8d1fee
  • Upwork Job ID: 1743327090406260736
  • Last Price Increase: 2024-01-17
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 5, 2024
@melvin-bot melvin-bot bot changed the title Workspace - Infinite loading when navigate to workspace link without access [$500] Workspace - Infinite loading when navigate to workspace link without access Jan 5, 2024
Copy link

melvin-bot bot commented Jan 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~013aa8ecc43f8d1fee

Copy link

melvin-bot bot commented Jan 5, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 5, 2024
Copy link

melvin-bot bot commented Jan 5, 2024

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Copy link

melvin-bot bot commented Jan 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@bernhardoj
Copy link
Contributor

Should be fixed in #34006

Copy link

melvin-bot bot commented Jan 8, 2024

@alexpensify, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@alexpensify
Copy link
Contributor

Ok, based on this news, I'm going to close this one.

@melvin-bot melvin-bot bot removed the Overdue label Jan 9, 2024
@alexpensify
Copy link
Contributor

Thanks for flagging!

@lanitochka17
Copy link
Author

Issue is still reproducible on the latest build 1.4.26-1

bandicam.2024-01-17.22-28-36-055.mp4

@lanitochka17 lanitochka17 reopened this Jan 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 17, 2024
@bernhardoj
Copy link
Contributor

This becomes a problem again after the introduction of finallyData which has the same root cause as #34466

Copy link

melvin-bot bot commented Jan 17, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@alexpensify
Copy link
Contributor

@bernhardoj - should we reopen #34006 or close this issue for #34466? Thanks for your feedback!

@melvin-bot melvin-bot bot removed the Overdue label Jan 17, 2024
@bernhardoj
Copy link
Contributor

@alexpensify maybe we can hold for #34466 and retest after it's deployed to staging. What do you think?

Copy link

melvin-bot bot commented Jan 19, 2024

@alexpensify @c3024 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@alexpensify alexpensify changed the title [$500] Workspace - Infinite loading when navigate to workspace link without access [HOLD - E# #34466] [$500] Workspace - Infinite loading when navigate to workspace link without access Jan 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 19, 2024
@alexpensify alexpensify changed the title [HOLD - E# #34466] [$500] Workspace - Infinite loading when navigate to workspace link without access [HOLD - EApp #34466] [$500] Workspace - Infinite loading when navigate to workspace link without access Jan 19, 2024
@alexpensify alexpensify added Weekly KSv2 and removed Daily KSv2 labels Jan 19, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jan 19, 2024
@alexpensify
Copy link
Contributor

Good plan, I'm updating this to be weekly and we can check in after #34466 is in production.

@alexpensify
Copy link
Contributor

Weekly Update: Still on hold

@alexpensify
Copy link
Contributor

Let's hold until next week, looks like there might be a regression.

@alexpensify
Copy link
Contributor

@c3024 - I think we should take this one off hold. Do you agree? Thanks!

@c3024
Copy link
Contributor

c3024 commented Feb 18, 2024

Not reproducible on main now. Could you check once @lanitochka17 ?

noContinuousLoading.mp4

@lanitochka17
Copy link
Author

Issue is not reproducible on the latest build 1.4.42-4

OVUO3592.MP4

@c3024
Copy link
Contributor

c3024 commented Feb 19, 2024

@alexpensify please close this. Issue is not reproducible anymore.

@alexpensify
Copy link
Contributor

alexpensify commented Feb 19, 2024

👍🏼 - thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants