Upload photo icon remains white in light mode #33689

ZhenjaHorbach · 2023-12-28T04:26:04Z

Theme - Upload photo icon remains white in light mode

Details

Theme - Upload photo icon remains white in light mode

Fixed Issues

$ #33316
PROPOSAL: #33316 (comment)

Tests

Sign in to any account
Go to Settings -> Preferences
Switch the App theme to light mode
Go to Settings -> Profile
Verify that the upload photo icon has a button background and icon color of light mode
Go to Settings -> Preferences again
Switch the App theme to dark mode
Go to Settings -> Profile again
Verify that the upload photo icon has a button background and icon color of dark mode

Verify that no errors appear in the JS console

Offline tests

Sign in to any account
Go to Settings -> Preferences
Switch the App theme to light mode
Go to Settings -> Profile
Verify that the upload photo icon has a button background and icon color of light mode
Go to Settings -> Preferences again
Switch the App theme to dark mode
Go to Settings -> Profile again
Verify that the upload photo icon has a button background and icon color of dark mode

QA Steps

Sign in to any account
Go to Settings -> Preferences
Switch the App theme to light mode
Go to Settings -> Profile
Verify that the upload photo icon has a button background and icon color of light mode
Go to Settings -> Preferences again
Switch the App theme to dark mode
Go to Settings -> Profile again
Verify that the upload photo icon has a button background and icon color of dark mode

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-28T04:26:09Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2023-12-28T05:48:23Z

@situchan
Hello )
PR is ready

ZhenjaHorbach · 2024-01-02T07:42:31Z

@situchan
Hello )
Friendly bump )

roryabraham · 2024-01-02T21:56:25Z

@situchan has a lot of higher priority things on his plate right now, so I'm going to find another C+ review for this one. https://expensify.slack.com/archives/C02NK2DQWUX/p1704232603966139

hoangzinh · 2024-01-02T22:30:06Z

@ZhenjaHorbach codes look good. But I'm thinking about testing steps:

Because this change will affect both dark & light mode, testing steps need to cover both dark & light mode
We're missing "Verify that" action, so it's not specific what are our assertions here

hoangzinh · 2024-01-02T23:31:08Z

Tests

Sign in to any account
Go to Settings -> Preferences
Switch the App theme to light mode
Go to Settings -> Profile
Verify that the upload photo icon has a button background and icon color of light mode
Go to Settings -> Preferences again
Switch the App theme to dark mode
Go to Settings -> Profile again
Verify that the upload photo icon has a button background and icon color of dark mode

what do you think @ZhenjaHorbach ?

hoangzinh · 2024-01-03T01:04:23Z

@ZhenjaHorbach also, the colors in your recordings look outdated. Can you help to do screenshot/record for all platforms with the latest code again? Thanks.

ZhenjaHorbach · 2024-01-03T05:49:00Z

Tests

Sign in to any account

Go to Settings -> Preferences

Switch the App theme to light mode

Go to Settings -> Profile

Verify that the upload photo icon has a button background and icon color of light mode

Go to Settings -> Preferences again

Switch the App theme to dark mode

Go to Settings -> Profile again

Verify that the upload photo icon has a button background and icon color of dark mode

what do you think @ZhenjaHorbach ?

looks good )

ZhenjaHorbach · 2024-01-03T05:49:37Z

@ZhenjaHorbach also, the colors in your recordings look outdated. Can you help to do screenshot/record for all platforms with the latest code again? Thanks.

And yes )
Sorry
These are screenshots from the previous implementation

But I've already updated everything)

ZhenjaHorbach · 2024-01-03T05:50:42Z

@hoangzinh
Now I think the PR is really completely ready)

hoangzinh · 2024-01-03T07:34:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Light mode	Dark mode

Android: mWeb Chrome

Light mode	Dark mode

Offline

Light mode	Dark mode

iOS: Native

Light mode	Dark mode

iOS: mWeb Safari

Light mode	Dark mode

Offline

Light mode	Dark mode

MacOS: Chrome / Safari

Light mode	Dark mode

Offline

Light mode	Dark mode

MacOS: Desktop

Light mode	Dark mode

Offline

Light mode	Dark mode

hoangzinh

Thanks @ZhenjaHorbach. PR LGTM

OSBotify · 2024-01-03T23:12:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-04T19:04:03Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:11:40Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-09T05:20:20Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix bug with Upload photo icon remains white in light mode

2366ade

ZhenjaHorbach requested a review from a team as a code owner December 28, 2023 04:26

melvin-bot bot requested review from situchan and removed request for a team December 28, 2023 04:26

Update colors

e5db886

roryabraham requested review from hoangzinh and removed request for situchan January 2, 2024 22:01

Update branch

a793301

hoangzinh approved these changes Jan 3, 2024

View reviewed changes

melvin-bot bot requested a review from roryabraham January 3, 2024 07:35

roryabraham approved these changes Jan 3, 2024

View reviewed changes

roryabraham merged commit 1d2b642 into Expensify:main Jan 3, 2024
18 checks passed

github-actions bot mentioned this pull request Jan 4, 2024

Deploy Checklist: New Expensify 2024-01-04 #33973

Closed

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upload photo icon remains white in light mode #33689

Upload photo icon remains white in light mode #33689

ZhenjaHorbach commented Dec 28, 2023 •

edited

Loading

melvin-bot bot commented Dec 28, 2023

ZhenjaHorbach commented Dec 28, 2023

ZhenjaHorbach commented Jan 2, 2024

roryabraham commented Jan 2, 2024 •

edited

Loading

hoangzinh commented Jan 2, 2024

hoangzinh commented Jan 2, 2024

hoangzinh commented Jan 3, 2024

ZhenjaHorbach commented Jan 3, 2024

Tests

ZhenjaHorbach commented Jan 3, 2024

ZhenjaHorbach commented Jan 3, 2024

hoangzinh commented Jan 3, 2024

hoangzinh left a comment

OSBotify commented Jan 3, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 9, 2024

Upload photo icon remains white in light mode #33689

Upload photo icon remains white in light mode #33689

Conversation

ZhenjaHorbach commented Dec 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 28, 2023

ZhenjaHorbach commented Dec 28, 2023

ZhenjaHorbach commented Jan 2, 2024

roryabraham commented Jan 2, 2024 • edited Loading

hoangzinh commented Jan 2, 2024

hoangzinh commented Jan 2, 2024

Tests

hoangzinh commented Jan 3, 2024

ZhenjaHorbach commented Jan 3, 2024

Tests

ZhenjaHorbach commented Jan 3, 2024

ZhenjaHorbach commented Jan 3, 2024

hoangzinh commented Jan 3, 2024

Reviewer Checklist

Screenshots/Videos

hoangzinh left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 3, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 9, 2024

ZhenjaHorbach commented Dec 28, 2023 •

edited

Loading

roryabraham commented Jan 2, 2024 •

edited

Loading