[$500] Expense - "This report will be reimbursed outside of Expensify" sentence disappears in thread

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.22-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of a Collect workspace on Old Dot

1. Go to workspace chat as employee
2. Create a manual request
3. Submit the report
4. As admin, pay the report elsewhere
5. As employee, click on the expense preview
6. Right click on the reimbursement message > Reply in thread

Expected Result:

The reimbursement message will not disappear in thread

Actual Result:

Part of the reimburment message - "This report will be reimbursed outside of Expensify" disappears in thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6333404_1704478227009.20240105_154652.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0188aabe1016612f59
• Upwork Job ID: 1743440258673152000
• Last Price Increase: 2024-01-06

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimbursement message disappears in thread header

What is the root cause of that problem?

We did not cover the case of MARKEDREIMBURSED in getReportName here and when we generate report name, we only take out the first item of message text which is You in this case.

What changes do you think we should make in order to solve the problem?

We should add the check to cover reimbursement message type and other cases of reimbursement messages like REIMBURSEMENTDEQUEUED or REIMBURSEMENTQUEUED as well inside isChatThread case.

if (parentReportAction.actionName === CONST.REPORT.ACTIONS.TYPE.MARKEDREIMBURSED) {
    return ReportActionsUtils.getMarkedReimbursedMessage(parentReportAction);
}

What alternative solutions did you explore? (Optional)

NA

[joelbettner]

@gijoe0295 can you provide some links to the code to describe where you're talking about?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0188aabe1016612f59

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[joelbettner]

cc: @Beamanator

[gijoe0295]

@joelbettner I added code changes and links.

[bernhardoj]

I think it's a BE issue. Every time we open the thread, the OpenReport (thread) gives a shorter message. If we go back to the chat report, the OpenReport (chat report) gives the complete message.

[ktejas]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Part of the reimburment message - "This report will be reimbursed outside of Expensify" disappears in thread

What is the root cause of that problem?

When calling openReport() we are passing reportID key's value instead of chatReportID key's value from the object "props.report".

What changes do you think we should make in order to solve the problem?

Fix the request body Payload to the API command 'OpenReport', by passing chatReportID instead of reportID in the Form Data key named 'reportID'.

What alternative solutions did you explore? (Optional)

Tried to reduce multiple API calls to OpenReport command. But ran out of time, couldn't figure out an alternate solution.

[melvin-bot]

📣 @ktejas! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[ktejas]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0152d06b5129e5b130

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mvtglobally]

Still repro on build 1.4.22-2

Recording.897.mp4

[melvin-bot]

Current assignee @getusha is eligible for the Internal assigner, not assigning anyone new.

[Beamanator]

Hmm honestly I don't think we want to be able to create a thread on this automated message...

@JmillsExpensify since we've talked about this system message showing up in NewDot (the You marked this report as manually reimbursed. This report will be reimbursed outside of Expensify message): Do you think users should be able to start threads from these comments or not?

[melvin-bot]

@joelbettner, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[joelbettner]

I think this issue is going to be resolved by the two linked issues and their respective PRs above. I'm going to close. @Beamanator @jasperhuangg feel free to open if you disagree.