[wave8] Ideal Nav Left Hand Panel Search #33499

WojtekBoman · 2023-12-22T16:03:11Z

This reverts commit 5b91c04, reversing changes made to 880254c.

Details

This PR covers the implementation of the Left Hand Pane and all fixes to this functionality.

Fixed Issues

$ #32939
PROPOSAL: described in the design doc here: https://docs.google.com/document/d/1VnEf2ThbbiQj0kx9KnAihF0DWf50s2Bn_MztEyEwtjg/edit#heading=h.r39uu4rszpv

Tests

Log in to the app.
Press on the search icon at the top of the sidebar.
Check if the search screen is opened on the left side of the screen.

Verify that no errors appear in the JS console

Offline tests

Log in to the app.
Press on the search icon at the top of the sidebar.
Check if the search screen is opened on the left side of the screen.

QA Steps

Log in to the app.
Press on the search icon at the top of the sidebar.
Check if the search screen is opened on the left side of the screen.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-12-14.at.14.24.02.mov

Android: mWeb Chrome

Screen.Recording.2023-12-14.at.14.29.23.mov

iOS: Native

Screen.Recording.2023-12-14.at.13.53.11.mov

iOS: mWeb Safari

Screen.Recording.2023-12-14.at.14.26.13.mov

MacOS: Chrome / Safari

Screen.Recording.2023-12-14.at.14.05.21.mov

MacOS: Desktop

Screen.Recording.2023-12-14.at.14.03.46.mov

…2473" This reverts commit 5b91c04, reversing changes made to 880254c.

melvin-bot · 2023-12-22T16:19:24Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-12-23T15:30:17Z

src/styles/index.ts

            ({
                ...positioning.pFixed,
                // We need to stretch the overlay to cover the sidebar and the translate animation distance.
-                left: -2 * variables.sideBarWidth,
+                // The overlay must also cover borderRadius of the LHP component


Suggested change

// The overlay must also cover borderRadius of the LHP component

s77rt · 2023-12-23T15:34:21Z

@WojtekBoman Did #32473 cause any regression?

s77rt · 2023-12-23T15:35:27Z

Opening the LHP (Search) is not animated

Screen.Recording.2023-12-23.at.4.34.31.PM.mov

mountiny · 2023-12-25T23:59:01Z

@s77rt I dont think there was any specific bug related to this, we removed the rounded corners from the LHP but that seems to be fixed here

WojtekBoman · 2024-01-02T09:36:52Z

@s77rt I've checked this animation issue and I think it might be a global issue in the app. I've made a comparison between this branch and main on a high traffic account and I have this issue on both branches. On a normal account this issue doesn't occur for me. Please check the attached videos :)

High traffic account (LHP & RHP):

Screen.Recording.2024-01-02.at.10.18.15.mov

Screen.Recording.2024-01-02.at.10.22.56.mov

My normal account (LHP):

Screen.Recording.2024-01-02.at.10.25.16.mov

mountiny · 2024-01-02T13:39:09Z

We have some other prs in motion to improve the search page opening

WojtekBoman · 2024-01-02T14:27:17Z

I've resolved all comments :) If this PR doesn't introduce an animation problem, can we proceed with it?

s77rt · 2024-01-02T14:38:18Z

Let me test once again and complete the checklist

s77rt · 2024-01-02T14:43:59Z

In my case the LHP feels pretty laggy, it almost stops then continue moving forward

Screen.Recording.2024-01-02.at.3.41.01.PM.mov

WojtekBoman · 2024-01-02T14:50:59Z

In my case the LHP feels pretty laggy, it almost stops then continue moving forward

Screen.Recording.2024-01-02.at.3.41.01.PM.mov

How does it behave with RHP? Is everything fine?

s77rt · 2024-01-02T14:54:50Z

@WojtekBoman Actually it's same performance. So nothing wrong in this PR. I guess I just don't use the Search option that much that I didn't notice this bug on main 😅

s77rt · 2024-01-02T14:58:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-01-02T14:59:17Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #32939 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

mountiny

Thanks for testing, this has worked before so i am going to go ahead and merge as no reason to wait

OSBotify · 2024-01-03T12:52:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-04T19:03:48Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-04T20:11:25Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.22-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-09T05:20:05Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.22-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Revert "Merge pull request Expensify#33406 from Expensify/vit-revert3…

0c2d395

…2473" This reverts commit 5b91c04, reversing changes made to 880254c.

WojtekBoman marked this pull request as ready for review December 22, 2023 16:19

WojtekBoman requested a review from a team as a code owner December 22, 2023 16:19

melvin-bot bot requested review from s77rt and removed request for a team December 22, 2023 16:19

s77rt suggested changes Dec 23, 2023

View reviewed changes

Merge branch 'main' into lhp-ideal-nav

bf3e22b

mountiny changed the title ~~Revert "Merge pull request #33406 from Expensify/vit-revert32473"~~ [wave8] Ideal Nav Left Hand Panel Search Dec 25, 2023

mountiny assigned WojtekBoman Dec 25, 2023

WojtekBoman added 2 commits January 2, 2024 09:50

Merge branch 'main' into lhp-ideal-nav

84de918

Remove the old comment from overlayStyles

b1e4300

s77rt approved these changes Jan 2, 2024

View reviewed changes

mountiny approved these changes Jan 3, 2024

View reviewed changes

mountiny merged commit 7c6b47d into Expensify:main Jan 3, 2024
16 checks passed

github-actions bot mentioned this pull request Jan 4, 2024

Deploy Checklist: New Expensify 2024-01-04 #33973

Closed

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wave8] Ideal Nav Left Hand Panel Search #33499

[wave8] Ideal Nav Left Hand Panel Search #33499

WojtekBoman commented Dec 22, 2023 •

edited

Loading

melvin-bot bot commented Dec 22, 2023

s77rt Dec 23, 2023

s77rt commented Dec 23, 2023

s77rt commented Dec 23, 2023

mountiny commented Dec 25, 2023

WojtekBoman commented Jan 2, 2024

mountiny commented Jan 2, 2024

WojtekBoman commented Jan 2, 2024

s77rt commented Jan 2, 2024 •

edited

Loading

s77rt commented Jan 2, 2024

WojtekBoman commented Jan 2, 2024

s77rt commented Jan 2, 2024

s77rt commented Jan 2, 2024

melvin-bot bot commented Jan 2, 2024

mountiny left a comment

OSBotify commented Jan 3, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 9, 2024

[wave8] Ideal Nav Left Hand Panel Search #33499

[wave8] Ideal Nav Left Hand Panel Search #33499

Conversation

WojtekBoman commented Dec 22, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 22, 2023

s77rt Dec 23, 2023

Choose a reason for hiding this comment

s77rt commented Dec 23, 2023

s77rt commented Dec 23, 2023

mountiny commented Dec 25, 2023

WojtekBoman commented Jan 2, 2024

mountiny commented Jan 2, 2024

WojtekBoman commented Jan 2, 2024

s77rt commented Jan 2, 2024 • edited Loading

s77rt commented Jan 2, 2024

WojtekBoman commented Jan 2, 2024

s77rt commented Jan 2, 2024

s77rt commented Jan 2, 2024

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Jan 2, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 3, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 4, 2024

OSBotify commented Jan 9, 2024

WojtekBoman commented Dec 22, 2023 •

edited

Loading

s77rt commented Jan 2, 2024 •

edited

Loading