Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-02] [HOLD for payment 2023-12-28] [$500] Implement Left Hand Nav #32939

Closed
hayata-suenaga opened this issue Dec 12, 2023 · 23 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Dec 12, 2023

As part of the Ideal Nav overhaul, implement the new Left Hand Panel and Left Hand Navigator according to the requirements specified in the design doc.

Parent Issue: #32689

Issue OwnerCurrent Issue Owner: @WojtekBoman
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015fa44a44c1c98c39
  • Upwork Job ID: 1737583619451142144
  • Last Price Increase: 2023-12-20
@hayata-suenaga hayata-suenaga added Weekly KSv2 NewFeature Something to build that is a new item. labels Dec 12, 2023
Copy link

melvin-bot bot commented Dec 12, 2023

@hayata-suenaga
Copy link
Contributor Author

@WojtekBoman from Software Mansion is going to work on this issue 🎉

@WojtekBoman
Copy link
Contributor

Comment for the assignment

@trjExpensify trjExpensify moved this to In Progress in Wave 8 Ideal Nav Dec 13, 2023
@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels Dec 13, 2023
@WojtekBoman WojtekBoman mentioned this issue Dec 14, 2023
47 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Dec 14, 2023
@adamgrzybowski
Copy link
Contributor

@hayata-suenaga This was merged and can be closed.

@hayata-suenaga
Copy link
Contributor Author

hayata-suenaga commented Dec 20, 2023

assinged @s77rt as the C+ for this issue for the payment for PR review

the PR was merged on Dec 18, Monday

cc: @alexpensify

@alexpensify
Copy link
Contributor

@hayata-suenaga was there an agreement set for the price or is this a standard payment of $500? Thanks!

@alexpensify
Copy link
Contributor

alexpensify commented Dec 20, 2023

Flagging the 7-day hold for the regression period will end on Thursday, December 28, 2023 and I can proceed forward with the payment process. I will be OOO next week but will try to get everything ready to avoid more delays.

@hayata-suenaga
Copy link
Contributor Author

yes the standard C+ review amount should be applied to this issue 🙇

@alexpensify alexpensify changed the title Implement Left Hand Nav [$500] Implement Left Hand Nav Dec 20, 2023
Copy link

melvin-bot bot commented Dec 20, 2023

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Dec 20, 2023
Copy link

melvin-bot bot commented Dec 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~015fa44a44c1c98c39

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 20, 2023
Copy link

melvin-bot bot commented Dec 20, 2023

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Dec 21, 2023
@melvin-bot melvin-bot bot changed the title [$500] Implement Left Hand Nav [HOLD for payment 2023-12-28] [$500] Implement Left Hand Nav Dec 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 21, 2023
Copy link

melvin-bot bot commented Dec 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.14-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment (Needs manual offer from BZ)
  • @WojtekBoman does not require payment (Contractor)

Copy link

melvin-bot bot commented Dec 21, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Dec 21, 2023
@s77rt
Copy link
Contributor

s77rt commented Dec 21, 2023

@alexpensify Applied! Thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 22, 2023
@alexpensify
Copy link
Contributor

Here is the payment summary:

  • External issue reporter - N/A
  • Contributor that fixed the issue - N/A
  • Contributor+ that helped on the issue and/or PR - @s77rt

Upwork Job: https://www.upwork.com/jobs/~015fa44a44c1c98c39

Extra Notes regarding payment: Heads up, I'm OOO until January 4, but I will log in on Friday, December 29 to complete this payment process pending no regression. I've confirmed that @s77rt is a pending hire, so all set here for the payment date.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 26, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-12-28] [$500] Implement Left Hand Nav [HOLD for payment 2024-01-02] [HOLD for payment 2023-12-28] [$500] Implement Left Hand Nav Dec 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2023
Copy link

melvin-bot bot commented Dec 26, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 26, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.16-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-01-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment (Needs manual offer from BZ)
  • @WojtekBoman does not require payment (Contractor)

Copy link

melvin-bot bot commented Dec 26, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@s77rt] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@s77rt
Copy link
Contributor

s77rt commented Dec 26, 2023

I don't think we require a regression test here since the expected behavior is unlikely to unexpectedly change

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 27, 2023
@alexpensify
Copy link
Contributor

Closing - Thank you everyone for your patience here. I've completed the payment process in Upwork and closed this job.

Happy New Year!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Wave 8 Ideal Nav Dec 29, 2023
Copy link

melvin-bot bot commented Jan 2, 2024

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

7 participants