Deploy Checklist: New Expensify 2023-07-19

[OSBotify]

Release Version: 1.3.43-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Apple sign-in #16723
• [Fix #21022] Improve performance by reducing re-renders SidebarLinks #21406
• fix rename room permission #22316
• Update Expense Request Headers / Empty State #22562
• [NoQA] refactor: migrate RadioButtons to function component #22770
• Fix: Web -Default avatar is changed when we select/unselect a member in Workspace invitation page #22791
• Silently fail flagComment request if reportAction has been deleted #22831
• Make sure the IOU or expense level settlement button defaults to last used method #22846
• fix: Send button does not appear when the internet connection is disabled #22981
• fix: The title field is cleared when the Confirm task button is pressed #22983
• fix Notfound when login from contact detail page #22988
• Update optimistic data for parent report action when completing or reopening task #22990
• fix navigating to thread when clicking on go to #admins or #announce room #23030
• Revert "Hide muted chats from LHN" #23037
• [NoQA] Fix: console warning by adding the missing values to target location for native devices #23042
• Pass policyID when adding a bank account #23045
• fix 22745: change filter rule to exclude pending delete workspace #23064
• [navigation-refactor] Change navigate to goBack after saving on paypal me page #23086
• fix: added maxLength to login and contact inputs #23095
• Fix report name on report footer is not dynamically updated #23098

Deploy Blockers:

• [HOLD for payment 2023-07-28] [HOLD for payment 2023-07-26] [$1000] IOU - No settlement button in the IOU report header #23083
• [HOLD for payment 2023-07-28] [HOLD for payment 2023-07-26] Clicking on 'From' link navigates to main chat rather than navigating to the previous IOU thread report #23102
• [HOLD for payment 2023-07-28] [HOLD for payment 2023-07-26] [$1000] IOU Report header shows back button even on large screens. #23123
• [$1000] [HOLD for payment 2023-08-02] Web - Space between the last message and time is more #23187
• [HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] Web - Workspace avatar is not updating after renaming #23189
• Desktop- Developer tools option not displayed #23190
• [HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] Room - Deleted message and broken avatar displayed in header for threaded reply in public room #23195
• [HOLD for payment 2023-08-01] [HOLD for payment 2023-07-28] IOU - IOU details are broken #23202
• [HOLD for payment 2023-08-15] App crashes when edited description of task #23210
• Log in - Apple icon is not present #23233
• [HOLD for payment 2023-08-01][$1000] Chat - App crashed while clicking on non-existed mention email #23250
• Log in - Sign with apple is not disable in offline mode #23257
• Web - Workspace image change for a second while adding or removing user #23262
• Chat - Flagging thread root message results in "This page cannot be found" #23264
• Login - Login screen becomes unresponsive when clicking to sign in with Apple offline #23265
• Desktop - Login - Magic link shows page with Magic code instead of prompt to open Desktop App #23285
• Workspace - Workspace editor opened after WS was created from the Global Create menu closes by itself #23287
• Sign in - Apple sign in is looped #23288
• Web - The sign in with apple button is not highlighted when hover over #23353

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.43-0 🚀

[jasperhuangg]

Checking off #23083 #23102 and #23123 since they were resolved in the last deploy. We seemed to have forgotten to remove the deploy blocker label.

[jasperhuangg]

Checking off #23187 it doesn't need to be a blocker

[aldo-expensify]

Checked off #23202, tested it and it is fixed

[aldo-expensify]

Checked off #23195, tested it and it is fixed

[mvtglobally]

We are still missing iOS build. Can you pls double check

[mountiny]

Checking #23287 off as non -repro anymore

[jasperhuangg]

I've retried the iOS build

[mountiny]

checking this one as it should be fixed by a CP #23189

[jasperhuangg]

Checking off all Apple sign in related PRs since the Apple sign in PR was reverted.

[jasperhuangg]

Checking off #23262 as it was decided not to deploy on it

[jasperhuangg]

Checking off #23210 we CP'd a revert to staging

[jasperhuangg]

It looks like we CP'd a fix for #23250 #23259 (comment), retested and it doesn't appear to be happening anymore, checking it off

[mvtglobally]

Team is working on the IOS, I will be updating checklist in a bit as we validate PRs on iOS

[jasperhuangg]

Checking off #16723 it was reverted

[mvtglobally]

Regression is down to the last 8%

PR summary
#16723 is failing #23288
#22562 is failing #23269
#22831 is failing #23264
#23098 is failing #23195

[mvtglobally]

@jasperhuangg Regression is completed

[mountiny]

Checking #23353 off, no more apple sign in on staging

[jasperhuangg]

#23269 repro in prod so checking off #22562

[jasperhuangg]