[HOLD for payment 2023-08-01][$1000] Chat - App crashed while clicking on non-existed mention email

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat.
2. Mention an non-existed email and press enter to send
3. Click on that mention
4. Notice that app is crashed

Expected Result:

App shouldn't be crash after clicking mention

Actual Result:

App crashed while clicking on non-existed mention email

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-20.at.14.43.03.mov

Recording.3769.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689839180058799

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01100b87f8a6a775ce
• Upwork Job ID: 1681996917328850944
• Last Price Increase: 2023-07-20

[hungvu193]

There's a discussion here to decide if this a regression: https://expensify.slack.com/archives/C049HHMV9SM/p1689839180058799

In case this is not a regression, I already posted my solution in the thread above.

We should pass login to our generateAccountID() function in here

 const optimisticAccountID = UserUtils.generateAccountID(login);

or at least add a initial value for searchValue of generateAccountID function.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[hungvu193]

@MariaHCD PR is ready! There's a lint issue but it's from main and being addressed by this PR
#23256 (cc @mountiny )

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01100b87f8a6a775ce

[melvin-bot]

Triggered auto assignment to @lschurr (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Current assignee @lschurr is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($1000)

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.44-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix crash while pressing mention #23259

If no regressions arise, payment will be issued on 2023-08-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hungvu193 requires payment
• @sobitneupane does not require payment (Eligable for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[lschurr]

Not overdue. Payment will happen tomorrow. I'll review today and note payments amounts.

[lschurr]

@sobitneupane - could you work on the checklist for this one?

[dylanexpensify]

@hungvu193 apologies if I missed this, but what was the verdict on this being a regression? And if so, who caused it?

[hungvu193]

@hungvu193 apologies if I missed this, but what was the verdict on this being a regression? And if so, who caused it?

@dylanexpensify Yeah, we have a discussion here about it:
https://app.slack.com/client/T03SC9DTT/C049HHMV9SM/thread/C049HHMV9SM-1689839180.058799

It was decided not a regression, but we should double check again latest main before merge PR into main to prevent this kind of issue happened.

For the reason:

1. A new param was added to generateAccountID in Expensify/App/pull/22791
2. But another PR used generateAccountID when there was no param added: Expensify/App/pull/23053
3. Expensify/App/pull/23053 was merged first and then a day later Expensify/App/pull/22791 was merged

[lschurr]

Payout summary:

• Bug reporter: @hungvu193 $250
• Contributor: @hungvu193 $1500
• Contributor+: @sobitneupane $1500

@hungvu193 will be paid in Upwork
@sobitneupane - be sure to request payment in Newdot.

[lschurr]

@sobitneupane could you also work on this checklist so that we can close this out? #23250 (comment)

[lschurr]

Bumped in Slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1691101805984369

[sobitneupane]

Sorry for the delay @lschurr. I will try to get to this issue by EOD.

[lschurr]

Just bumping @sobitneupane :)

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

Discussion related to the culprit PR: https://expensify.slack.com/archives/C049HHMV9SM/p1689839180058799

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://expensify.slack.com/archives/C049HHMV9SM/p1689839180058799

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

https://expensify.slack.com/archives/C049HHMV9SM/p1689852466206849?thread_ts=1689839180.058799&cid=C049HHMV9SM

• [@sobitneupane] Determine if we should create a regression test for this bug.

I don't think specific regression test is required for this issue.

[sobitneupane]

Requested payment on newDot.

#23250 (comment)

[lschurr]

Thanks @sobitneupane - going to close this one!

[JmillsExpensify]

Reviewed the payment details for @sobitneupane. $1,500 is approved for payment in NewDot.