Desktop - Login - Magic link shows page with Magic code instead of prompt to open Desktop App

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

. Open Desktop App
2. Create new account
3. Got to validation email and copy magic link
4. Open new tab, paste magic link and change it to staging
5. Go to this Magic link

Expected Result:

Prompt to open the Desktop App should appear

Actual Result:

Magic code page loads instead of prompt to open Desktop App

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6135383_Login-MagicCode-instead-of-Open-Desktop.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[0xmiros]

This came from apple sign-in PR and we already agreed to disable opening desktop app on unauthorized pages for now.
cc: @marcochavezf

[marcochavezf]

Hmm we disable them on unauthorized pages thinking that we were not cases where we prompt the user to open the desktop app there, but it seems there's indeed a case for this. @lindboe I'm afraid that we'd need to move the DeeplinkWrapper to PublicScreens again or come up with a solution to use them in both PublicScreens and AuthScreens.

[iwiznia]

Reverting the offending PR

[lindboe]

Yes, this means we'll need to instead block DeeplinkWrapper from activating on a certain list of routes. I think the ones that make sense are the dedicated desktop sign-in page, and the main sign-in page (to avoid prompting the user to go to the desktop app, then back to the web app if they had wanted to sign in with Apple). I'll try again to confirm in Slack.

[marcochavezf]

Closing out since Apple sign-in PR was reverted

[lindboe]

I just tried to test this out on prod (new.expensify.com) as well to figure out what we need to support, and I noticed the same behavior of no redirect prompt Firefox on MacOS. Safari does prompt to redirect that link. I'm not sure why the difference yet, as I haven't seen Firefox not trigger a deep link prompt when I would expect one.

edit: I'm told we specifically don't support Firefox, and that is why