Request money - Request view header is missing details

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #22562

Action Performed:

1. Open staging.new.expensify.com
2. Request IOU from user B
3. Open request view
4. Observe request header

Expected Result:

Header details to appear without missing data

Actual Result:

No header details; only username and avatar are displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

4.mov

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b1218ae0575ebba7
• Upwork Job ID: 1683452239429439488
• Last Price Increase: 2023-07-24

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BhuvaneshPatil]

bumping @neil-marcellini - please have a look if changes for #23102 causing this.

[trjExpensify]

Hey @lanitochka17, the video in the OP doesn't match the steps listed. I can repro the bug though:

CC: @grgia as well, it seems like something undid the work in your PR :)

[trjExpensify]

@neil-marcellini, do we need to revert #23102 or what are the next steps here?

[grgia]

checking if this will be fixed by https://github.com/Expensify/App/pull/22467/files

[grgia]

Looks like the expense request avatars did get bonked, I'll fix them in the above PR

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b1218ae0575ebba7

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

[grgia]

I'm not sure what caused the header regression, still looking

[neil-marcellini]

Thanks for taking this on @grgia! Did #23102 cause the regression or something else?

[BhuvaneshPatil]

I have tried debugging this and found the cause for this issue, I am submitting the proposal for the same. Let me know your thoughts

[BhuvaneshPatil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request View header is missing details.

What is the root cause of that problem?

We try to get the text below the name (in blue color) in AvatarWithDisplayName.

using ReportUtils.getParentNavigationSubtitle(), in case of Request Money it's IOU report -
it falls into this condition -

https://github.com/BhuvaneshPatil/App/blob/b7d17e0fd33b83e9fbd45146b6123b6323ece79e/src/libs/ReportUtils.js#L1193-L1197

As mentioned in the comment above function -

https://github.com/BhuvaneshPatil/App/blob/b7d17e0fd33b83e9fbd45146b6123b6323ece79e/src/libs/ReportUtils.js#L1182C1-L1183C97

As the final report is IOU, we won't recursively calculate. This we return displayName

https://github.com/BhuvaneshPatil/App/blob/b7d17e0fd33b83e9fbd45146b6123b6323ece79e/src/libs/ReportUtils.js#L1194-L1196

This display name is empty. See below screenshot -

I have tried testing this for multiple IOU reports, still the same.

Thus it doesn't the text in AvatarWithDisplayNames
https://github.com/BhuvaneshPatil/App/blob/b7d17e0fd33b83e9fbd45146b6123b6323ece79e/src/components/AvatarWithDisplayName.js#L93-L108

What changes do you think we should make in order to solve the problem?

We shall change -

rootReportName: lodashGet(report, 'displayName', ''),

to

rootReportName: lodashGet(report, 'displayName', '') || getReportName(report),

This will make sure that we take value from getReportName(report) when displayName is empty.

result -

What alternative solutions did you explore? (Optional)

[trjExpensify]

@grgia do we need to add the reviewing label here because of the linked PR: #23269 (comment)

[grgia]

Added reviewing label

[BhuvaneshPatil]

Please have a look at this. I understand that this is internal but It may give some direction for solution.

[melvin-bot]

@trjExpensify, @grgia, @0xmiroslav Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

This was deployed a few days ago. The linked PR wasn't reviewed by C+ and this bug was reported by Applause, so I'm closing it out!