Update optimistic data for parent report action when completing or reopening task #22990

dukenv0307 · 2023-07-17T10:42:15Z

Details

Update optimistic data for parent report action when completing or reopening task

Fixed Issues

$ #20570
PROPOSAL: #20570 (comment)

Tests

Login with any account
Go to FAB > Assign task
Enter the title, description and go to the next step
Choose Assignee and ShareSomeWhere
Confirm the task
Go offline
Go to the parent report of the task
Click on the checkbox to complete the task
Verify that the thread item appears and the thread count is correct
Click on the checkbox again to reopen the task
Verify that the thread count is updated correctly

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Login with any account
Go to FAB > Assign task
Enter the title, description and go to the next step
Choose Assignee and ShareSomeWhere
Confirm the task
Go offline
Go to the parent report of the task
Click on the checkbox to complete the task
Verify that the thread item appears and the thread count is correct
Click on the checkbox again to reopen the task
Verify that the thread count is updated correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.17-07-2023.17.45.54.webm

Mobile Web - Chrome

Record_2023-07-17-17-49-24.mp4

Mobile Web - Safari

safari.mp4

Desktop

desktop.2.mp4

iOS

ios.2.mp4

Android

20570.mp4

…opening task

melvin-bot · 2023-07-17T11:19:37Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-07-19T02:49:57Z

@aimane-chnaif Friendly bump.

aimane-chnaif

I see 4 duplicated code parts. Can we make common function for this?

aimane-chnaif · 2023-07-19T12:59:46Z

@aimane-chnaif Because we need to get parentReportActionID to update optimistic data so I just create a common to get the optimisticData of parentReportAcrion.

yes, I thought about making common like this:

const getOptimisticDataForParentReportAction = (reportID, lastVisibleActionCreated, type) => {
    // Optimistically update the parent report action if the report is a thread
    const report = ReportUtils.getReport(reportID);
    if (report && report.parentReportActionID) {
        const parentReportAction = ReportActionsUtils.getParentReportAction(report);
        if (parentReportAction && parentReportAction.reportActionID) {
            return [
                {
                    onyxMethod: Onyx.METHOD.MERGE,
                    key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`,
                    value: {
                        [parentReportAction.reportActionID]: ReportUtils.updateOptimisticParentReportAction(parentReportAction, lastVisibleActionCreated, type),
                    },
                },
            ];
        }
    }
    return [];
};

dukenv0307 · 2023-07-19T13:00:16Z

@aimane-chnaif I think we can refactor updateOptimisticParentReportAction function to avoid this.

aimane-chnaif · 2023-07-19T13:01:09Z

@aimane-chnaif I think we can refactor updateOptimisticParentReportAction function to avoid this.

yes, let's do that

dukenv0307 · 2023-07-19T13:21:42Z

@aimane-chnaif Updated with the common, please help to check again.

aimane-chnaif

One minor change:

src/libs/ReportUtils.js

Co-authored-by: Aimane Chnaif <[email protected]>

dukenv0307 · 2023-07-19T13:36:31Z

Updated.

aimane-chnaif · 2023-07-19T13:56:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

aimane-chnaif

@MariaHCD LGTM 🎉

MariaHCD

One comment/suggestion but otherwise, looks good!

src/libs/actions/Report.js

Co-authored-by: Maria D'Costa <[email protected]>

OSBotify · 2023-07-19T16:19:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-19T17:59:53Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-07-20T18:20:54Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-07-21T18:51:51Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-22T00:19:02Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.43-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:25:48Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

situchan · 2023-11-06T18:51:43Z

src/libs/actions/Report.js

+    // Update optimistic data for parent report action if the report is a child report
+    const optimisticParentReportData = ReportUtils.getOptimisticDataForParentReportAction(reportID, optimisticReport.lastVisibleActionCreated, CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
+    if (!_.isEmpty(optimisticParentReportData)) {
+        optimisticData.push(optimisticParentReportData);


Coming from #26012:
I won't say it's a regression but it could have been perfect if below case was handled as well:

If deleted message in thread has visible child actions, childVisibleActionCount of parentReportAction should not be decreased

fedirjh · 2024-04-12T04:20:32Z

src/libs/actions/Report.js

-            });
-        }
+    // Update optimistic data for parent report action if the report is a child report
+    const optimisticParentReportData = ReportUtils.getOptimisticDataForParentReportAction(reportID, currentTime, CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD);


Coming from #38002 , we should have updated the optimistic data for each ancestor thread.

update optimistic data for parent report action when completing or re…

03f4a3e

…opening task

dukenv0307 marked this pull request as ready for review July 17, 2023 11:19

dukenv0307 requested a review from a team as a code owner July 17, 2023 11:19

melvin-bot bot requested review from aimane-chnaif and removed request for a team July 17, 2023 11:19

aimane-chnaif reviewed Jul 19, 2023

View reviewed changes

dukenv0307 added 2 commits July 19, 2023 20:06

Merge branch 'main' into fix/20570

088b26c

create common to get optimistic data for parent report action

d73809d

aimane-chnaif reviewed Jul 19, 2023

View reviewed changes

src/libs/ReportUtils.js Outdated Show resolved Hide resolved

Update src/libs/ReportUtils.js

174e335

Co-authored-by: Aimane Chnaif <[email protected]>

aimane-chnaif approved these changes Jul 19, 2023

View reviewed changes

melvin-bot bot requested a review from MariaHCD July 19, 2023 13:57

MariaHCD reviewed Jul 19, 2023

View reviewed changes

src/libs/actions/Report.js Outdated Show resolved Hide resolved

dukenv0307 and others added 2 commits July 19, 2023 23:01

Update src/libs/actions/Report.js

bb613da

Co-authored-by: Maria D'Costa <[email protected]>

format if statements

bcd496a

MariaHCD approved these changes Jul 19, 2023

View reviewed changes

MariaHCD merged commit 40f354b into Expensify:main Jul 19, 2023

OSBotify mentioned this pull request Jul 19, 2023

Deploy Checklist: New Expensify 2023-07-19 #23183

Closed

42 tasks

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

melvin-bot bot mentioned this pull request Jul 21, 2023

[HOLD for payment 2023-07-28] [$1000] Offline - Thread - Count reply does not update when completing or reopening a task #20570

Closed

6 tasks

situchan reviewed Nov 6, 2023

View reviewed changes

situchan mentioned this pull request Nov 6, 2023

[HOLD for payment 2023-11-06] [$1000] Chat - When we delete some messages from a thread, the rest of the undeleted messages disappear #26012

Closed

6 tasks

fedirjh reviewed Apr 12, 2024

View reviewed changes

fedirjh mentioned this pull request Apr 12, 2024

[HOLD for payment 2024-04-09] [$500] LOW - Android-Thread-Incorrect number of replies displayed for multilevel thread when going back #38002

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update optimistic data for parent report action when completing or reopening task #22990

Update optimistic data for parent report action when completing or reopening task #22990

dukenv0307 commented Jul 17, 2023 •

edited

Loading

melvin-bot bot commented Jul 17, 2023

dukenv0307 commented Jul 19, 2023

aimane-chnaif left a comment

aimane-chnaif commented Jul 19, 2023

dukenv0307 commented Jul 19, 2023

aimane-chnaif commented Jul 19, 2023

dukenv0307 commented Jul 19, 2023

aimane-chnaif left a comment

dukenv0307 commented Jul 19, 2023

aimane-chnaif commented Jul 19, 2023

aimane-chnaif left a comment

MariaHCD left a comment

OSBotify commented Jul 19, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 20, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 22, 2023

OSBotify commented Jul 25, 2023

situchan Nov 6, 2023

fedirjh Apr 12, 2024

Update optimistic data for parent report action when completing or reopening task #22990

Update optimistic data for parent report action when completing or reopening task #22990

Conversation

dukenv0307 commented Jul 17, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 17, 2023

dukenv0307 commented Jul 19, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

aimane-chnaif commented Jul 19, 2023

dukenv0307 commented Jul 19, 2023

aimane-chnaif commented Jul 19, 2023

dukenv0307 commented Jul 19, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

dukenv0307 commented Jul 19, 2023

aimane-chnaif commented Jul 19, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

MariaHCD left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 19, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 20, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 22, 2023

OSBotify commented Jul 25, 2023

situchan Nov 6, 2023

Choose a reason for hiding this comment

fedirjh Apr 12, 2024

Choose a reason for hiding this comment

dukenv0307 commented Jul 17, 2023 •

edited

Loading