Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update optimistic data for parent report action when completing or reopening task #22990

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Update optimistic data for parent report action when completing or reopening task #22990

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
03f4a3e
update optimistic data for parent report action when completing or re…
dukenv0307 Jul 17, 2023
088b26c
Merge branch 'main' into fix/20570
dukenv0307 Jul 19, 2023
d73809d
create common to get optimistic data for parent report action
dukenv0307 Jul 19, 2023
174e335
Update src/libs/ReportUtils.js
dukenv0307 Jul 19, 2023
bb613da
Update src/libs/actions/Report.js
dukenv0307 Jul 19, 2023
bcd496a
format if statements
dukenv0307 Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions src/libs/actions/Task.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,25 @@ function completeTask(taskReportID, taskTitle) {
},
];

// Optimistically update the parent report action
const report = ReportUtils.getReport(taskReportID);
if (report && report.parentReportActionID) {
const parentReportAction = ReportActionsUtils.getParentReportAction(report);
if (parentReportAction && parentReportAction.reportActionID) {
optimisticData.push({
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`,
value: {
[parentReportAction.reportActionID]: ReportUtils.updateOptimisticParentReportAction(
parentReportAction,
completedTaskReportAction.created,
CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
),
},
});
}
}

API.write(
'CompleteTask',
{
Expand Down Expand Up @@ -314,6 +333,25 @@ function reopenTask(taskReportID, taskTitle) {
},
];

// Optimistically update the parent report action
const report = ReportUtils.getReport(taskReportID);
if (report && report.parentReportActionID) {
const parentReportAction = ReportActionsUtils.getParentReportAction(report);
if (parentReportAction && parentReportAction.reportActionID) {
optimisticData.push({
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`,
value: {
[parentReportAction.reportActionID]: ReportUtils.updateOptimisticParentReportAction(
parentReportAction,
reopenedTaskReportAction.created,
CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
),
},
});
}
}

API.write(
'ReopenTask',
{
Expand Down