Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-02-07 #14911

Closed
21 tasks done
OSBotify opened this issue Feb 7, 2023 · 13 comments
Closed
21 tasks done

Deploy Checklist: New Expensify 2023-02-07 #14911

OSBotify opened this issue Feb 7, 2023 · 13 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Feb 7, 2023

Release Version: 1.2.67-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 7, 2023
@mountiny mountiny self-assigned this Feb 7, 2023
@mountiny mountiny added the Daily KSv2 label Feb 7, 2023
@Expensify Expensify deleted a comment from MelvinBot Feb 7, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 7, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.67-5 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 7, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.67-5 has been deployed to staging 🎉

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 8, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 8, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.67-6 🚀

@roryabraham
Copy link
Contributor

Checked off #12983

@mvtglobally
Copy link

@mountiny Regression is completed

We are checking few CPs
#14669 is blocked on IOS #13882 (comment) and failing on mWeb with #14937 (repro in prod)
#11565 is failing #14929
#14290 is failing on Native aps #14949. this is not repro in PROD, but we didnt add a blocker label as the feature introduced by PR. Pls double check this one

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2023

Thank you @mvtglobally

I think:

#14290 is failing on Native aps #14949. this is not repro in PROD, but we didnt add a blocker label as the feature introduced by PR. Pls double check this one

Is alright, if you add valid date it works correctly and its just one platform, the original PR has been a big change so we are fine to proceed I think

#14669 is blocked on IOS #13882 (comment) and failing on mWeb with #14937 (repro in prod)

this also seems fine to me

#11565 is failing #14929

We might want to revert that PR

@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 8, 2023

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.67-7 🚀

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2023

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2023

Graphs and crashes seem fine, waiting for last CP verification

@mvtglobally
Copy link

#14955 looks good

@OSBotify
Copy link
Contributor Author

OSBotify commented Feb 8, 2023

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.67-7 has been deployed to staging 🎉

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2023

Thank you, deploying!

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2023

:shipit:

@mountiny mountiny closed this as completed Feb 8, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants