Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb -Chat- The LHN page is visible for a moment when opening the URL of conversation #14937

Closed
1 of 6 tasks
kbecciv opened this issue Feb 8, 2023 · 9 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #14669

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log into NewDot with an existing account that has more than 2 chats
  3. Copy the relative path from an existing chat report
  4. Navigate to another chat or page and then use the relative from step 2 to open the chat

Expected Result:

The correct chat is opened

Actual Result:

The LHN page is visible for a moment when opening the URL of conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.67.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5928882_Record_2023-02-08-02-06-44.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 8, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 8, 2023
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2023

cc @marcochavezf I think we dont have to fix this I think this could be re-evaluated after the navigation refactor

@MelvinBot
Copy link

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@marcochavezf
Copy link
Contributor

Thanks @mountiny, sounds good. Just curious, do you know what is the latest of the navigation refactor?

@mountiny
Copy link
Contributor

mountiny commented Feb 9, 2023

@marcochavezf we are working on the detailed design doc section at the moment, the proof of concept seems to be working great 🎉 lets hope that can be transported to App as well

@melvin-bot melvin-bot bot added the Overdue label Feb 10, 2023
@MelvinBot
Copy link

@stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

1 similar comment
@MelvinBot
Copy link

@stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

@stephanieelliott
Copy link
Contributor

Cool, sounds like this is being addressed in the nav refractor!

@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants