Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing Address field in AddDebitCardPage doesn't accept text #14918

Closed
2 of 6 tasks
hayata-suenaga opened this issue Feb 7, 2023 · 45 comments
Closed
2 of 6 tasks

Billing Address field in AddDebitCardPage doesn't accept text #14918

hayata-suenaga opened this issue Feb 7, 2023 · 45 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Feb 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

Break down in numbered steps

  1. Go to Settings > Payments
  2. Tap Add payment method > Debit card
  3. Try to type in Billing Address field

Expected Result:

Inputted text should be displayed.

Actual Result:

Text doesn't appear when text is inputted.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

I tried to paste a text in the field instead of typing, but it doesn't work either. No workaround found.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C03TQ48KC/p1675793090919109

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011c6f32902f1a74c9
  • Upwork Job ID: 1623035041406087168
  • Last Price Increase: 2023-02-07
@hayata-suenaga hayata-suenaga added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 7, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 7, 2023
@MelvinBot
Copy link

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Feb 7, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@hayata-suenaga hayata-suenaga changed the title Billing Address field in Add Debit card Page doesn't accept text Billing Address field in AddDebitCardPage doesn't accept text Feb 7, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 7, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Feb 7, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@aldo-expensify
Copy link
Contributor

Removing @grgia because @hayata-suenaga is working on it and I think he already found the cause

@hayata-suenaga
Copy link
Contributor Author

maxInputLength prop that is passed to TextInput inside AddressSearch component seems to the the root cause.

@mountiny
Copy link
Contributor

mountiny commented Feb 7, 2023

Can you confirm what versions this is happening on, we just had a deploy so I want to know if this is in production now or the fresh new staging. In which case it would not be a deploy blocker.

@hayata-suenaga hayata-suenaga added the Internal Requires API changes or must be handled by Expensify staff label Feb 7, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 7, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~011c6f32902f1a74c9

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

@aldo-expensify
Copy link
Contributor

aldo-expensify commented Feb 7, 2023

Can you confirm what versions this is happening on, we just had a deploy so I want to know if this is in production now or the fresh new staging. In which case it would not be a deploy blocker.

@mountiny I tested in production and it is not there oh, you just deployed.. testing again

@aldo-expensify
Copy link
Contributor

@mountiny I tested with version v1.2.65-2

@mountiny
Copy link
Contributor

mountiny commented Feb 7, 2023

Ok yeah so that is production now so this does not have to be a deploy blocker! But I think we should still CP to Staging the fix so this gets out sooner

@melvin-bot melvin-bot bot added the Overdue label Feb 20, 2023
@hayata-suenaga
Copy link
Contributor Author

This issue is being held until the QA can have a test debit card to implement the above testing steps.

@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 28, 2023
@aldo-expensify
Copy link
Contributor

Issue about testing debit card credential for QA: https://github.com/Expensify/Expensify/issues/226985

@melvin-bot melvin-bot bot removed the Overdue label Mar 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 9, 2023
@hayata-suenaga
Copy link
Contributor Author

I thought if the issue title has [HOLD], melvin-bot will be chill. does anyone know if we created a test card for QA team to use?

@melvin-bot melvin-bot bot removed the Overdue label Mar 9, 2023
@mountiny
Copy link
Contributor

No, HOLD does not stop melvin, only Reviewing does, but that should only be used for actual PR being in a review.

You can also change the priority of the issue if appropriate

@hayata-suenaga hayata-suenaga added Monthly KSv2 and removed Weekly KSv2 labels Mar 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@aldo-expensify
Copy link
Contributor

aldo-expensify commented Apr 12, 2023

I think Applause has the ability to test with cards now: https://github.com/Expensify/Expensify/issues/226985#issuecomment-1502170174

@hayata-suenaga we should be able to proceed with updating the test: #14918 (comment)

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2023
@aldo-expensify aldo-expensify changed the title [HOLD E/E #226985 for regression steps]Billing Address field in AddDebitCardPage doesn't accept text Billing Address field in AddDebitCardPage doesn't accept text Apr 12, 2023
@mallenexpensify
Copy link
Contributor

Dropped in #qa to ask about getting this tested
https://expensify.slack.com/archives/C9YU7BX5M/p1681317318570329

@hayata-suenaga
Copy link
Contributor Author

@hayata-suenaga he should be able to proceed with updating the test: #14918 (comment)

Has the comment already been updated?

@trjExpensify trjExpensify added Daily KSv2 and removed Monthly KSv2 labels Apr 13, 2023
@trjExpensify
Copy link
Contributor

👋 Noticed this in the +4 weeks old WAQ dashboard. There isn't a hold in the title anymore, dropping back to Daily.

@aldo-expensify
Copy link
Contributor

@hayata-suenaga he should be able to proceed with updating the test: #14918 (comment)

Has the comment already been updated?

Sorry, which comment?

@hayata-suenaga
Copy link
Contributor Author

@aldo-expensify nvm I was confused between updating testing steps in the original comment and actual Applause tests 😅

@mallenexpensify
Copy link
Contributor

@mvtglobally can you test this?

Here's Maria's reply in #QA

we can add Debit card now. Only issue tester faced when set the newly added debit card as the default payment method - Default label is NOT present ( Step 10 - Add debit card section). Team logged two issue related default payment #16911 and #16914
Let me know if I need to log a separate issue for Debit Card.

@mvtglobally
Copy link

I will update in the morning with details

@mallenexpensify
Copy link
Contributor

Thanks @mvtglobally , I'm going to close then. Comment/reopen if needed.

@MelvinBot
Copy link

@mallenexpensify @aldo-expensify @hayata-suenaga Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests