IOS - Deep link doesn't direct to the IOS app when creating a new account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. In the email field enter a email the new Expensify account and click on continue
3. Verify there’s a message saying that a Magic Link has been sent to the email address
4. Copy the dip link and paste it into notepad
5. In the notebook, change to staging
6. Click this dip link

Expected Result:

The deep link should point to the iOS app when creating a new account

Actual Result:

Deep link doesn't direct to the IOS app when created a new account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• iOS / native

Version Number: 1.2.45.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5879830_dip_link_ios_2812.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[jasperhuangg]

This is actually expected, if we want to deeplink to the native app then the URL needs to have a different format, it's actually correct that we redirect to the web browser for any links that look like https://staging.new.expensify.com...

I don't think this is a bug per se. I think in other apps when you try to deeplink it will also bring you to the web app to do validation. I'm electing to close this out

[marcaaron]

@jasperhuangg I'm not sure if I understood the decision. Why would a link with staging.new.expensify.com not be an acceptable deep link? We have the acceptable schemes listed here:

App/src/libs/Navigation/linkingConfig.js

Lines 6 to 13 in 1c45763

	prefixes: [
	'new-expensify://',
	'https://www.expensify.cash',
	'https://staging.expensify.cash',
	'http://localhost',
	CONST.NEW_EXPENSIFY_URL,
	CONST.STAGING_NEW_EXPENSIFY_URL,
	],

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[jasperhuangg]

@marcaaron good shout, didn't realize that we also handled links with the format staging.new.expensify.com to the iOS app. This issue was correctly reported.

I'm gonna keep this closed since there's a dupe issue already: #15158