Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-02-17] [HOLD for payment 2023-02-15] Log In- Secondary login Logged out of NewDot is show message error #14948

Closed
6 tasks done
kbecciv opened this issue Feb 8, 2023 · 7 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Logout of NewDot
  2. Log into OldDot with any account and add a Secondary Login from Account Settings e.g. [email protected]
  3. Open validate secondary log in email Verify secondary email for Expensify and copy the last part of the URL, i.e. /v/16/WSSWMNNM (Everything after the /v/)
  4. In a text box - Formulate the URL by using the path obtained from step 3 http://staging.new.expensify.com/v/
  1. Navigate to the compiled link
  2. On Login>password page Enter your password and login

Expected Result:

The user Log In the app without any error

Actual Result:

A message error is shown after Login in app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.67.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3145567

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5929637_Error_SecondayLogion.mp4
T3145627-SecondaryLogin-Logout-User.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Feb 8, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 8, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Feb 8, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2023

Seems like this must be related to this PR #11565

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Feb 8, 2023
@marcochavezf marcochavezf removed the Reviewing Has a PR in review label Feb 8, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Feb 8, 2023
@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2023

This should be deployed now, thank you for help!

@mountiny mountiny closed this as completed Feb 8, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Feb 8, 2023
@melvin-bot melvin-bot bot changed the title Log In- Secondary login Logged out of NewDot is show message error [HOLD for payment 2023-02-15] Log In- Secondary login Logged out of NewDot is show message error Feb 8, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 8, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 8, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-02-15. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 10, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-02-15] Log In- Secondary login Logged out of NewDot is show message error [HOLD for payment 2023-02-17] [HOLD for payment 2023-02-15] Log In- Secondary login Logged out of NewDot is show message error Feb 10, 2023
@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.68-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-02-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants