refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button)!: remove deprecated `intl*` properties #5982

anveshmekala · 2022-12-10T02:00:46Z

BREAKING CHANGE: Removed deprecated intl* properties , use messageOverrides property instead.

action:
- Removed the property intlLoading , use messsageOverrides.loading instead.
- Removed the property intlIndicator, use messageOverrides.indicator instead.
action-bar:
- Removed the property intlExpand , use messsageOverrides.expand instead.
- Removed the property intlCollapse, use messageOverrides.collapse instead.
action-group:
- Removed the property intlMore , use messsageOverrides.more instead.
action-pad:
- Removed the property intlExpand , use messsageOverrides.expand instead.
- Removed the property intlCollapse, use messageOverrides.collapse instead.
alert:
- Removed the property intlClose, use messageOverrides.close instead.
block:
- Removed the property intlExpand , use messsageOverrides.expand instead.
- Removed the property intlCollapse, use messageOverrides.collapse instead.
- Removed the property intlLoading , use messsageOverrides.loading instead.
- Removed the property intlOptions, use messageOverrides.options instead.
block-section:
- Removed the property intlExpand , use messsageOverrides.expand instead.
- Removed the property intlCollapse, use messageOverrides.collapse instead.
button:
- Removed the property intlLoading , use messsageOverrides.loading instead.

* feat(color-picker): add built-in translations * drop defaults since these are now translated * remove leftover default prop assertion Co-authored-by: Anveshreddy mekala <[email protected]>

* feat(scrim): add built-in translations * set asset dir and drop optional prop as all props are made optional * wire up lifecycle utils * fix copy pasta 🍝🤦 * add effectiveLocale watcher

* feat(popover): add built-in translations * set asset dir * add initial message load * add effectiveLocale watcher * simplify pattern by not needing to watch default messages

…slations

* feat(panel): add built-in translations * add deprecation note * add t9n bundle for flow-item and wire it up for translations * add test * add initial message load * remove duplicate identifiers Co-authored-by: Anveshreddy mekala <[email protected]>

* feat(value-list): add built-in translations * set asset dir * add initial message load * add effectiveLocale watcher * drop unused string from bundles * fix token replacement Co-authored-by: Anveshreddy mekala <[email protected]>

…slations

* feat(notice): add built-in translations * refactor * remove TEXT from resource

* feat(inline-editable): add built-in translations * fix typo in bundles * clean up

* feat(filter): add built-in translations * remove lang parsing in shadowDom * fix test errors & rename messages * clean up

* feat(combobox): add built-in translations * add assetsDir * remove default value for intl props * cleanup * clean up

* feat(card): add built-in translations * missing lifecycle event * refactor * fix test errors * clean up * fix axe errors * clean up

* feat(block,block-section): add built-in translations * feedback changes * fix test errors * remove default test assertions for intl props * clean up

* feat(alert): add support for built-in translations * refactor * fix build errors * refactor * clean up

* feat(chip): add built-in translations * add util method to test non intl props

…slations

#5416) * feat: add built-in translations * add bundles * remove obsolete folder * add type generator * rename type's file * delete non-t9n file * commit lock file * rename type generating script and tidy up * regenerate interface files * update color-picker file * add missing value-list entries * inline common strings until we have common bundle wired up * revert unnecessary tsconfig changes * update interface files * add util to fetchbundles and supported locale * feedback changes * more cleanup * remove intl default value validation in e2e * sync en.json with en-US.json bundle * rename script * refactor script file * remove console.log * refactor & add back types to intl props in colorpicker * add util method for string over rides * tidy up * simplify t9n pattern * fix issue caused by type + interface TS shape confusion * support nb&no for norwegian locale * add cache for stringBundle fetch * tidy up * drop intl from string bundle keys * update scripts to use messages as string bundle name * rename bundles * rename interface props * add t9ntest util methods * restore intlProp watching to pattern * use extended mutation observer to simplify unobserving * add intl prop watcher doc * add support for cascading lang * tidy up * update conventions doc with pattern info * update doc * drop and ignore generated d.ts files and tweak messages type names * wire up interface generation before build * merge w other * refactor localized components pattern * refactor t9n pattern to work w/ localized component * tidy up * fix utils depending on defined locale and not placeholder one * consolidate t9n tests and make intl prop merging happen at run time * Updated Pseudo i18n - @jian9413 * feat(time-picker,input-time-picker): add built-in translations support * ensure connectLocale happens before code that depends on locale * convert effectiveLocale to internla prop * cherry pick lang inheritance changes * update doc * tidy up * make lang lookup more robust * update doc * tidy up * fix test errors * add comments * remove intl resources * fix typo * clean up * forward intlProps Co-authored-by: JC Franco <[email protected]> Co-authored-by: Ben Elan <[email protected]> Co-authored-by: jona7150 <[email protected]>

…slations

…tion (#5404) * feat: add built-in translations * add bundles * remove obsolete folder * add type generator * rename type's file * delete non-t9n file * commit lock file * rename type generating script and tidy up * regenerate interface files * update color-picker file * add missing value-list entries * inline common strings until we have common bundle wired up * revert unnecessary tsconfig changes * update interface files * add util to fetchbundles and supported locale * feedback changes * more cleanup * remove intl default value validation in e2e * sync en.json with en-US.json bundle * rename script * refactor script file * remove console.log * refactor & add back types to intl props in colorpicker * add util method for string over rides * tidy up * simplify t9n pattern * fix issue caused by type + interface TS shape confusion * support nb&no for norwegian locale * add cache for stringBundle fetch * tidy up * drop intl from string bundle keys * update scripts to use messages as string bundle name * rename bundles * rename interface props * add t9ntest util methods * restore intlProp watching to pattern * use extended mutation observer to simplify unobserving * add intl prop watcher doc * add support for cascading lang * tidy up * update conventions doc with pattern info * update doc * drop and ignore generated d.ts files and tweak messages type names * wire up interface generation before build * merge w other * refactor localized components pattern * refactor t9n pattern to work w/ localized component * tidy up * fix utils depending on defined locale and not placeholder one * consolidate t9n tests and make intl prop merging happen at run time * Updated Pseudo i18n - @jian9413 * feat(date-picker): add support for built-in translations * fix test errors * cleanup * moved localization setup before setting values that depend on locale in inputs * update other components that depend on locale being defined early when connected * update usage of effectiveLocale within composite components * localize input-date-picker * support translation updates when lang attr is deleted * update package lock * revert duplicate changes * update package-lock * remove input-time-picker changes * revert color-picker changes * revert change log and package lock changes * cleanup * more cleanup * feedback changes * add markdown for compound components * revert markdown changes * change nb to no in locales array * fix test errors * support cldr lang's * doc update * revert no to nb * cleanup * more cleanup * update comments * remove intl resources * clean up * add comments * revert order of locales Co-authored-by: JC Franco <[email protected]> Co-authored-by: Ben Elan <[email protected]> Co-authored-by: jona7150 <[email protected]>

* feat(input-number, input, input-text): add built-in translations * fix test errors * restore TEXT in resources * prettify * remove duplicate code * refactor

* feat(rating): add built-in translations * set asset dir * add initial message load * add effectiveLocale watcher * fix outdated reference * update lang switch helper to account for strings used in rendering * feat(time-picker, input-time-picker): add numberingSystem property (#5301) * feat(time-picker, input-time-picker): add numberingSystem property for localization * wip: need to correctly apply numberingSystem on InputInput * use NumberStringFormat to delocalize time * cleanup * delocalize time on blur * test(input-time-picker): fix e2e failures and add numberingSystem story * use formatter's format method instead of localize for performance * cleanup * fix(input-time-picker): don't pass through lang and numberingSystem to calcite-input * fix test * use NumberStringFormat's setter instead of setOptions Co-authored-by: Ben Elan <[email protected]> * refactor(block): move hardcoded classes to CSS object (#5474) * fix(input, input-number, input-text): fix input icons not displaying properly in Firefox (#5475) #5417 * ci(next): clean docs build before deployment (#5476) * ci(prepReleaseCommit): skip git sanity checks for next releases * ci(next): clean docs build before deployment * Revert "ci(prepReleaseCommit): skip git sanity checks for next releases" This reverts commit 7cc2d8b. Co-authored-by: Ben Elan <[email protected]> * refactor(input-number, input-text): drop resize-icon selectors (#5477) * fix(block): improve content layout (#5473) #5422 * docs: update component READMEs (#5479) Co-authored-by: jcfranco <[email protected]> * docs: add backticks to props and values for consistency (#5485) * docs: add backticks to props and values for consistency * update prop ref * review edits * fix(date-picker): no longer hides year for zh-CN locale (#5344) * fix(date-picker): no longer hides year for zn-CH locale * add screener story * fix locale typo * fix suffix placement * docs(changelog): add missing breaking changes (#5469) * feat(stepper, stepper-item): add numberingSystem property (#5467) * feat(stepper, stepper-item): add numberingSystem property * use setter for NumberStringFormat's options instead of setOptions * change formatter options in effectiveLocale watcher * cleanup Co-authored-by: Ben Elan <[email protected]> * fix(flow-item): fix scrollContentTo (#5487) #5414 * ci(next): fix next releases take 3 (#5497) * ci(next): fix next releases take 3 * cleanup Co-authored-by: Ben Elan <[email protected]> * fix(flow-item, panel): fix layout issue that would cause double scrollbars (#5486) #5428 * 1.0.0-next.598 * docs: update component READMEs (#5501) Co-authored-by: jcfranco <[email protected]> * build(deps): bump eslint-plugin-jest from 27.1.1 to 27.1.2 (#5507) Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 27.1.1 to 27.1.2. - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v27.1.1...v27.1.2) --- updated-dependencies: - dependency-name: eslint-plugin-jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump shell-quote from 1.7.3 to 1.7.4 (#5503) Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.7.3 to 1.7.4. - [Release notes](https://github.com/ljharb/shell-quote/releases) - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@1.7.3...v1.7.4) --- updated-dependencies: - dependency-name: shell-quote dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @typescript-eslint/eslint-plugin from 5.38.1 to 5.40.1 (#5506) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.38.1 to 5.40.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump @typescript-eslint/parser from 5.38.1 to 5.40.1 (#5504) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.38.1 to 5.40.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.40.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump eslint-plugin-jsdoc from 39.3.6 to 39.3.13 (#5505) Bumps [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc) from 39.3.6 to 39.3.13. - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v39.3.6...v39.3.13) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(tree, tree-item): works when tree is the topmost element in a shadow root where it has no parent (#5472) #5333 * ci: fix next releases take 4 (#5500) * ci: fix next releases take 4 * separate error messages Co-authored-by: Ben Elan <[email protected]> * 1.0.0-next.599 * fix(flow-item): Render back button first. (#5511) * 1.0.0-next.600 * fix(tab): applies section styles onto the enclosing parent (#5516) * WIP: temorary demo swap with the issue case * fix(tab): applies section styles onto the enclosing parent * revert to original demo * cleanup * TabChilrenWithPercentageHeights story * cleanup * swap parent selector for [role=tabpanel] * Introduce a new class selector * 1.0.0-next.601 Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ben Elan <[email protected]> Co-authored-by: Ben Elan <[email protected]> Co-authored-by: Calcite Admin <[email protected]> Co-authored-by: jcfranco <[email protected]> Co-authored-by: Kitty Hurley <[email protected]> Co-authored-by: Anveshreddy mekala <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eliza Khachatryan <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matt Driscoll <[email protected]>

* feat(pick-list-item): add built-in translations * add deprecation note and wire up messages in rendering * add initial message load * add missing type Co-authored-by: anveshmekala <[email protected]>

* feat(pagination): add built-in translations * simplify string keys to match others * add deprecation note * introduce context for locale lookup as translation locales do not necessarily map to supported ones * standardize Norwegian language code Co-authored-by: Anveshreddy mekala <[email protected]>

* feat(modal): add built-in translations * add assets directory * remove intl from resource * clean up * fix test failure * refactor

…slations

…o anveshmekala/5946-remove-intl-deprecations

driskull

👍

driskull · 2022-12-14T23:17:37Z

src/components/action-bar/action-bar.tsx

@@ -348,7 +332,6 @@ export class ActionBar
      <ExpandToggle
        el={el}
        expanded={expanded}
-        // rename intl properties for 1.0


can you create an issue to rename these functional component params? post 1.0 :)

driskull · 2022-12-14T23:18:26Z

src/components/action-pad/action-pad.tsx

@@ -155,6 +139,8 @@ export class ActionPad
  // --------------------------------------------------------------------------

  connectedCallback(): void {
+    connectLocalized(this);


were these missing?

this is a duplicate. will get this removed.

driskull · 2022-12-14T23:18:41Z

src/components/action/resources.ts

@@ -12,7 +12,7 @@ export const CSS = {

 export const TEXT = {
  loading: "Loading",


do we still need this text export?

nope. removed.

anveshmekala · 2022-12-15T00:13:38Z

src/components/action/action.tsx

@@ -295,7 +278,6 @@ export class Action
      buttonId,
      messages
    } = this;
-
    const ariaLabel = `${label || text}${indicator ? ` (${messages.indicator})` : ""}`;


are parantheses in (${messages.indicator}) intentional ?

Yes, they are intentional.

* master: (21 commits) 1.0.0-next.685 refactor(modal)!: Renamed property and updated values (#6054) 1.0.0-next.684 refactor(tab-nav, tab-title)!: remove `event.detail` payload from events (#6046) refactor(tree)!: remove `event.detail` payload from events (#6051) docs(changelog): fix breaking change indent levels (#6057) 1.0.0-next.683 refactor(pagination)!: remove `event.detail` payload from events (#6047) refactor(dropdown)!: remove `event.detail` payload from events (#6044) refactor(rating)!: remove `event.detail` payload from events (#6045) refactor(inline-editable,input,input-text,input-number)!: remove deprecated `intl*` properties (#6049) 1.0.0-next.682 refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated `intl*`properties (#6053) docs: update component READMEs (#6052) 1.0.0-next.681 refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker): remove deprecated `intl*` & accessible label properties (#6041) refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated `intl*` properties (#5982) 1.0.0-next.680 refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename `disable*` properties (#6036) refactor(input-date-picker)!: Remove deprecated calciteDatePickerChange event (#6040) ...

anveshmekala and others added 30 commits October 13, 2022 12:48

feat: add built-in translations

ac26754

feat(color-picker): add built-in translations (#5431)

52a9d65

* feat(color-picker): add built-in translations * drop defaults since these are now translated * remove leftover default prop assertion Co-authored-by: Anveshreddy mekala <[email protected]>

feat(scrim): add built-in translations (#5435)

71726ce

* feat(scrim): add built-in translations * set asset dir and drop optional prop as all props are made optional * wire up lifecycle utils * fix copy pasta 🍝🤦 * add effectiveLocale watcher

feat(popover): add built-in translations (#5436)

2b2b9cc

* feat(popover): add built-in translations * set asset dir * add initial message load * add effectiveLocale watcher * simplify pattern by not needing to watch default messages

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

47d0c19

…slations

feat(value-list): add built-in translations (#5438)

26f3ffd

* feat(value-list): add built-in translations * set asset dir * add initial message load * add effectiveLocale watcher * drop unused string from bundles * fix token replacement Co-authored-by: Anveshreddy mekala <[email protected]>

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

e368bf8

…slations

add missing type

e2b4e82

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

eb9a474

…slations

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

a2ed4d4

…slations

feat(notice): add built-in translations (#5463)

c4e619b

* feat(notice): add built-in translations * refactor * remove TEXT from resource

feat(inline-editable): add built-in translations (#5457)

1a6afcd

* feat(inline-editable): add built-in translations * fix typo in bundles * clean up

feat(filter): add built-in translations (#5456)

f8e0449

* feat(filter): add built-in translations * remove lang parsing in shadowDom * fix test errors & rename messages * clean up

feat(combobox): add built-in translations (#5455)

f538b4e

* feat(combobox): add built-in translations * add assetsDir * remove default value for intl props * cleanup * clean up

feat(card): add built-in translations (#5450)

e259a55

* feat(card): add built-in translations * missing lifecycle event * refactor * fix test errors * clean up * fix axe errors * clean up

feat(block,block-section): add built-in translations (#5446)

85070de

* feat(block,block-section): add built-in translations * feedback changes * fix test errors * remove default test assertions for intl props * clean up

feat(alert): add support for built-in translations (#5444)

4baa273

* feat(alert): add support for built-in translations * refactor * fix build errors * refactor * clean up

feat(chip): add built-in translations (#5465)

21bdc0d

* feat(chip): add built-in translations * add util method to test non intl props

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

b5b2471

…slations

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

8c47836

…slations

feat(input-number, input, input-text): add built-in translations (#5458)

0a9779a

* feat(input-number, input, input-text): add built-in translations * fix test errors * restore TEXT in resources * prettify * remove duplicate code * refactor

feat(pick-list-item): add built-in translations (#5434)

ffe5f83

* feat(pick-list-item): add built-in translations * add deprecation note and wire up messages in rendering * add initial message load * add missing type Co-authored-by: anveshmekala <[email protected]>

feat(modal): add built-in translations (#5462)

935c607

* feat(modal): add built-in translations * add assets directory * remove intl from resource * clean up * fix test failure * refactor

replace nb with no in e2e

c24f313

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

9a46ab1

…slations

anveshmekala added 3 commits December 9, 2022 17:55

add support for zh locale

ceb9860

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

dd2fc7e

…slations

refactor(action): remove translation properties

57da09c

anveshmekala changed the base branch from master to anveshmekala/4961-add-built-in-pseudo-translations December 10, 2022 02:01

anveshmekala added 2 commits December 12, 2022 10:03

Merge branch 'master' into anveshmekala/4961-add-built-in-pseudo-tran…

3a69a60

…slations

Merge branch 'anveshmekala/4961-add-built-in-pseudo-translations' int…

3043395

…o anveshmekala/5946-remove-intl-deprecations

anveshmekala added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Dec 12, 2022

anveshmekala changed the title ~~refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove translation properties~~ refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated translation properties Dec 12, 2022

Base automatically changed from anveshmekala/4961-add-built-in-pseudo-translations to master December 14, 2022 21:20

Merge branch 'master' into anveshmekala/5946-remove-intl-deprecations

27163fb

github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 14, 2022

github-actions bot assigned anveshmekala Dec 14, 2022

anveshmekala changed the title ~~refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated translation properties~~ refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated intl* properties Dec 14, 2022

anveshmekala added 2 commits December 14, 2022 15:44

Merge branch 'master' into anveshmekala/5946-remove-intl-deprecations

b499f16

fix test errors

0870a4f

anveshmekala marked this pull request as ready for review December 14, 2022 22:43

anveshmekala requested a review from a team as a code owner December 14, 2022 22:43

anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 14, 2022

driskull approved these changes Dec 14, 2022

View reviewed changes

anveshmekala added 2 commits December 14, 2022 17:57

feedback changes

01f5384

add paranthesis to indicator text

3f81462

anveshmekala commented Dec 15, 2022

View reviewed changes

Merge branch 'master' into anveshmekala/5946-remove-intl-deprecations

e5b0283

anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 15, 2022

anveshmekala merged commit 88040c8 into master Dec 15, 2022

anveshmekala deleted the anveshmekala/5946-remove-intl-deprecations branch December 15, 2022 00:34

github-actions bot added this to the 2023 January Priorities milestone Dec 15, 2022

anveshmekala changed the title ~~refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated intl* properties~~ refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button)!: remove deprecated intl* properties Dec 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button)!: remove deprecated `intl*` properties #5982

refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button)!: remove deprecated `intl*` properties #5982

anveshmekala commented Dec 10, 2022 •

edited

Loading

driskull left a comment

driskull Dec 14, 2022

anveshmekala Dec 15, 2022

driskull Dec 14, 2022

anveshmekala Dec 14, 2022

driskull Dec 14, 2022

anveshmekala Dec 14, 2022

anveshmekala Dec 15, 2022

anveshmekala Dec 15, 2022

driskull Dec 15, 2022

		@@ -12,7 +12,7 @@ export const CSS = {

		export const TEXT = {
		loading: "Loading",

refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button)!: remove deprecated intl* properties #5982

refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button)!: remove deprecated intl* properties #5982

Conversation

anveshmekala commented Dec 10, 2022 • edited Loading

driskull left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button)!: remove deprecated `intl*` properties #5982

refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button)!: remove deprecated `intl*` properties #5982

anveshmekala commented Dec 10, 2022 •

edited

Loading