feat(time-picker,input-time-picker): add built-in translations support #5416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into anveshmekala/4961-time-picker-add-built-in-localization-suppport
anveshmekala
changed the base branch from
jcfranco/4961-add-built-in-localization-to-components
to
master
…-localization-suppport
…-localization-suppport
…-localization-suppport
anveshmekala
added
the
pr ready for visual snapshots
anveshmekala
removed
the
pr ready for visual snapshots
jcfranco
approved these changes
Oct 19, 2022
| @@ -1053,4 +1053,6 @@ describe("calcite-time-picker", () => { | |||
| expect(meridiemStart).toBeTruthy(); | |||
| }); | |||
| }); | |||
|
|
|||
| it("suuports translation", () => t9n("<calcite-time-picker></calcite-time-picker>")); | |||
There was a problem hiding this comment.
This can be simplified by passing the tag.
anveshmekala
changed the base branch from
master
to
anveshmekala/4961-add-built-in-pseudo-translations
anveshmekala
merged commit 22d21db
into
anveshmekala/4961-add-built-in-pseudo-translations
anveshmekala
deleted the
anveshmekala/4961-time-picker-add-built-in-localization-suppport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4961
Summary
This PR will add support for translations in
calcite-time-pickerandcalcite-input-time-pickercomponents.