Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rating)!: remove event.detail payload from events #6045

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

driskull
Copy link
Member

BREAKING CHANGE: Removed event.detail payload from events.

  • Removed the event.detail property on the event calciteRatingChange, use event.target instead.

@driskull driskull changed the title refactor(rating)!: remove event.detail payload from events. #6007 refactor(rating)!: remove event.detail payload from events Dec 15, 2022
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 15, 2022
@driskull driskull marked this pull request as ready for review December 15, 2022 01:08
@driskull driskull requested a review from a team as a code owner December 15, 2022 01:08
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@driskull driskull merged commit 7fc2796 into master Dec 15, 2022
@driskull driskull deleted the dris0000/rating-event-detail branch December 15, 2022 16:43
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 15, 2022
benelan added a commit that referenced this pull request Dec 15, 2022
* master: (21 commits)
  1.0.0-next.685
  refactor(modal)!: Renamed property and updated values (#6054)
  1.0.0-next.684
  refactor(tab-nav, tab-title)!: remove `event.detail` payload from events (#6046)
  refactor(tree)!: remove `event.detail` payload from events (#6051)
  docs(changelog): fix breaking change indent levels (#6057)
  1.0.0-next.683
  refactor(pagination)!: remove `event.detail` payload from events (#6047)
  refactor(dropdown)!: remove `event.detail` payload from events (#6044)
  refactor(rating)!: remove `event.detail` payload from events (#6045)
  refactor(inline-editable,input,input-text,input-number)!: remove deprecated `intl*` properties (#6049)
  1.0.0-next.682
  refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated `intl*`properties (#6053)
  docs: update component READMEs (#6052)
  1.0.0-next.681
  refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker): remove deprecated `intl*` & accessible label properties (#6041)
  refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated `intl*` properties (#5982)
  1.0.0-next.680
  refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename `disable*` properties (#6036)
  refactor(input-date-picker)!: Remove deprecated calciteDatePickerChange event (#6040)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants