Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scrim): add built-in translations #5435

Conversation

jcfranco
Copy link
Member

Related Issue: #4961

Summary

Wires up translations to the scrim component.

@jcfranco jcfranco requested a review from a team as a code owner October 11, 2022 02:24
@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Oct 11, 2022
@jcfranco jcfranco requested a review from anveshmekala October 11, 2022 02:26
@anveshmekala anveshmekala changed the base branch from master to anveshmekala/4961-add-built-in-pseudo-translations October 13, 2022 22:41
Copy link
Contributor

@anveshmekala anveshmekala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥💥💥💥💥💥💥💥💥

@anveshmekala anveshmekala merged commit 71726ce into anveshmekala/4961-add-built-in-pseudo-translations Oct 17, 2022
@anveshmekala anveshmekala deleted the jcfranco/4961-add-built-in-localization-for-scrim branch October 17, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants