[Combobox] Input values are not filtering properly

[tresh11178]

Actual Behavior

When inputting certain values, the Combobox dropdown does not properly filter the options as expected.

Expected Behavior

The expectation is that all values should be filtered properly based on the input from the user.

Reproduction Sample

https://codepen.io/tre11178/pen/KKZXMYW?editors=100

Reproduction Steps

1. Click into the Combobox
2. Type "F" into the input.
3. Notice that the dropdown is not filtering out all options other than "Fire Safety Team".
4. Type "Fi" into the input.
5. Notice the dropdown is still not filtering.
6. Type "Fir" into the input.
7. Notice that the dropdown properly filters.

Reproduction Version

beta.80

Relevant Info

No response

Regression?

No response

[benelan]

[Implementer Notes]: This is probably because the forIn function "Iterates over own and inherited enumerable properties of an object invoking iteratee for each property."

All of the combobox-items are matching the word "define"

[github-actions]

Installed and assigned for verification.

[geospatialem]

@Elijbet I'm seeing some filtering issues with a few letters on next. Put together an updated codepen for reference. Can you take a peek 👀?

Note: Added an additional item to showcase filtering further, but tested across the alphabet.

Some of the filtering experienced:

• d, For results must type "di"
• e, For results must type "edi"
• f, For results must type "fir"
• n, For results must type "na"
• u, For results must type "ur"

[Elijbet]

Sure, I'll check now. It might be that with the newer solution we ended up leaving other properties in there still.

[benelan]

Yeah that's what I thought. Its not just the guid, its the inherited properties too. The first solution worked IIRC.

[benelan]

Or if I'm wrong and the const inputSubset = (({ label, value }) => ({ label, value }))(input as any); didn't work, I'd look into Object.hasOwn.

[Elijbet]

Yeah that's what I thought. Its not just the guid, its the inherited properties too. The first solution worked IIRC.

It's the right thing to do, to remove the guid there. But I should still only filter the subset of the input object. And I'll try your suggestion as well @benelan

[benelan]

Yeah agreed, we don't need the guid there. I was just referring to when I requested changes. That's my fault, I should have been clearer in my note above about the inherited enumerable properties being the issue.

[geospatialem]

Going to reallocate this on back to in development. Thanks for the background/insights @benelan and for investigating, @Elijbet!

[github-actions]

Installed and assigned for verification.

[geospatialem]

Verified on next ✔️