Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Combobox] filtering does not work when Item text labels are not unique #6814

Closed
mjuniper opened this issue Apr 19, 2023 · 2 comments
Closed

[Combobox] filtering does not work when Item text labels are not unique #6814

mjuniper opened this issue Apr 19, 2023 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2023 September Pr...

Comments

@mjuniper
Copy link
Member

Actual Behavior

When calcite-combobox contains multiple calcite-combobox-items with the same text-label, filtering breaks.

Expected Behavior

I expect filtering to work.

Reproduction Sample

https://codepen.io/mjuniper/pen/JjmRQpV?editors=1000

Reproduction Steps

  1. Click in the combobox
  2. type "conf"

Expected: the combobox groups/items would be filtered to just the ones in the "arcgis-configuration-editor" group.

Observed: The items are not filtered.

Reproduction Version

1.2.0

Relevant Info

This issue seems similar but it is closed.

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Esri team

ArcGIS Hub
@mjuniper mjuniper added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Apr 19, 2023
@github-actions github-actions bot added ArcGIS Hub Issues logged by ArcGIS Hub team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Apr 19, 2023
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. labels Jul 19, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 19, 2023
@jcfranco jcfranco self-assigned this Sep 7, 2023
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Sep 7, 2023
@jcfranco jcfranco mentioned this issue Sep 8, 2023
Merged
jcfranco added a commit that referenced this issue Sep 8, 2023
@jcfranco
fix(combobox): fix filtering to avoid showing unrelated items (#7704)
b6d32f3 
**Related Issue:** #6814 

## Summary

This fixes an issue with the logic matching items to the internal
filtered data. Filtered data corresponds to items, so both `label` and
`value` need to match vs one or the other.

Also, hidden groups are visually hidden now. They were being displayed
because the host was missing the base `hidden` styles.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Sep 8, 2023
@github-actions github-actions bot assigned geospatialem and unassigned jcfranco Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Sep 11, 2023
@geospatialem
Copy link
Member

Verified in 1.8.1-next.0
verify-filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Hub Issues logged by ArcGIS Hub team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2023 September Priorities - Main release
Development

No branches or pull requests
3 participants
@jcfranco @mjuniper @geospatialem