fix(combobox, filter): only test regex on string properties when filtering #4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
benelan
commented
Apr 25, 2022
src/components/filter/filter.tsx
Outdated
| @@ -158,7 +158,7 @@ export class Filter implements InteractiveComponent { | |||
| if (find(val, RE)) { | |||
| found = true; | |||
| } | |||
| } else if (RE.test(val)) { | |||
| } else if (typeof val === "string" && RE.test(val)) { | |||
| found = true; | |||
There was a problem hiding this comment.
@jcfranco should this also accept number typed values? Maybe if there is a rating property or something that people want to filter by
There was a problem hiding this comment.
The current version changes the filtering behavior, right? I think pick/value list items allow passing metadata objects that go through filtering.
How about returning if the value is null or undefined instead?
if (typeof val === "function" || val == null /* intentional == to catch undefined */) {
return;
}
if (Array.isArray(val) || typeof val === "object") { /* ... */ }
{ else if (RE.test(val)) { /* ... */ }
Elijbet
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4348
Summary
It was matching the
constantattribute'sundefineddefault value.Fixing it this way also works for
calcite-filter, rather than only filtering based onlabelandvalueproperties (relevant for #4425)