Elijbet/4348 fix combobox input value filtering #4404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irst/last-item-into-focus-scroll-into-view
…age to the very top, End scrolls to bottom
…irst/last-item-into-focus-scroll-into-view
…tbox to be consistent Dropdown behavior
…irst/last-item-into-focus-scroll-into-view
…irst/last-item-into-focus-scroll-into-view
…irst/last-item-into-focus-scroll-into-view
…irst/last-item-into-focus-scroll-into-view
…ptive per comments
…irst/last-item-into-focus-scroll-into-view
…irst/last-item-into-focus-scroll-into-view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4348
Summary
The Combobox dropdown does not properly filter the options as expected.
While filtering, the find function implements a lodash function
forInto iterate through passed in input properties. As is, it goes through all of the properties, including a property called guid. This is a longish letter string, and it’s matching almost everything typed in.The solution here is to make a subset of the input object with only value and label properties before passing it in, so only relevant properties get to be iterated on.