Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release / 4.6 #2233

Merged
merged 272 commits into from
Aug 4, 2021
Merged

Release / 4.6 #2233

merged 272 commits into from
Aug 4, 2021

Conversation

vsubhuman
Copy link
Contributor

@vsubhuman vsubhuman commented Jul 14, 2021

Milestone: https://github.com/Emurgo/yoroi-frontend/milestone/3?closed=1

Initial Change Set

oskin1 and others added 30 commits May 27, 2021 13:02
# Conflicts:
#	packages/yoroi-extension/package-lock.json
Add github actions to do flow and lint checks
… a library code and we can't change it to a more generic expectation
When we updated sigma-rust the flow types weren't updated which caused
ergoplatform/sigma-rust@30be67d
to give us undefined instead of 1 or 2.
…nfo-in-ui-backport

# Conflicts:
#	packages/yoroi-ergo-connector/package-lock.json
…port

[PULL] Fix round info in UI (backport!)
[PULL] Latest Production to Develop
Conflicts:
	packages/yoroi-extension/app/api/ada/lib/cardanoCrypto/catalyst.test.js
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman
Copy link
Contributor Author

Double-checked in release-candidate, looks good:

image

Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman
Copy link
Contributor Author

vsubhuman commented Aug 3, 2021

Double-checked in release-candidate on testnet. Works great!

Specifically aggregated entire balance into a single UTxO using "Send all", then created one new tx sending 1.8 ADA to my own address, which spent the only existing aggregated UTxO, and then produced the 1.8 UTxO as first in the queue and then the change UTxO with the rest of the balance as second in the queue. Creating a new tx for 1 ADA after that forced the coin-selector to pick the first UTxO for 1.8 and then decide what to do next, and the screenshot shows how it used the second additional UTxO specifically to reduce the fee, even tho the first UTxO would suffice for the sending amount and the fee all by itself, but would incur unnecessary higher burn.

image

This fixes this issue perfectly: #2235

Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman
Copy link
Contributor Author

@vsubhuman vsubhuman marked this pull request as ready for review August 4, 2021 10:15
@vsubhuman vsubhuman merged commit c58ac53 into production Aug 4, 2021
@vsubhuman vsubhuman deleted the release/4.6 branch August 4, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants