Ledger wallet Catalyst voting registration support #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #8804: Make Trezor wallet Catalyst registration work at API level. |
yushih
force-pushed
the
yushi/catalyst-ledger
branch
2 times, most recently
from
50f0937 to
4906ae9
Compare
yushih
force-pushed
the
yushi/catalyst-ledger
branch
from
4906ae9 to
6b90742
Compare
yushih
force-pushed
the
yushi/catalyst-ledger
branch
from
03828bf to
9ad0b5e
Compare
|
@yushih , plz resolve conflicts |
yushih
force-pushed
the
yushi/catalyst-ledger
branch
from
b2d933d to
8858abb
Compare
Conflicts: packages/yoroi-extension/app/api/ada/lib/cardanoCrypto/catalyst.test.js
yushih
force-pushed
the
yushi/catalyst-ledger
branch
from
3d4c389 to
cf1f408
Compare
vsubhuman
approved these changes
Jun 16, 2021
Merged
This was referenced Jul 14, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ch8804]
Prerequisite: this change Emurgo/yoroi-extension-ledger-connect-handler@3ebe9bc be published to NPM as version 5.0.0
Because when Ledger signs the tx, it only returns the signature part of the CIP-15 aux data, in
VotingStore._createTransactionI have to pass the staking pub key and reward address along with the staking key path down the call chain. And inLedgerSendStore.signAndBroadcast, I construct the aux data (akametadata) using the data passed down and the signature returned from Ledger and put it into the tx body.