Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.5.6] Ledger support backport #2215

Merged
merged 11 commits into from
Jul 7, 2021
Merged

[4.5.6] Ledger support backport #2215

merged 11 commits into from
Jul 7, 2021

Conversation

vsubhuman
Copy link
Contributor

yushih added 11 commits July 7, 2021 02:36
@yushih @vsubhuman
Ledger wallet Catalyst voting registration
c201070 
(cherry picked from commit 6b90742)
@yushih @vsubhuman
fix getting public staking key
c1c7f31 
(cherry picked from commit 85cce64)
@yushih @vsubhuman
fix fee by using a placeholder metadata
37124ab 
(cherry picked from commit 9ad0b5e)
@yushih @vsubhuman
use Mary era aux data format as Ledger does
53d8279 
(cherry picked from commit 6d5f357)
@yushih @vsubhuman
show firmware version error if version is too low
360d344 
(cherry picked from commit e873bac)
@yushih @vsubhuman
enable Ledger wallet Catalyst voting registration
12c4509 
(cherry picked from commit 03f1a5d)
@yushih @vsubhuman
fix catalyst registration progress steps for hw wallets
4dffef6 
(cherry picked from commit 62b0846)
@yushih @vsubhuman
move the delegation status alert message to top of dialog
92d3e0a 
(cherry picked from commit 95c4d7e)
@yushih @vsubhuman
show requirements for hardware wallets
2f90fbc 
(cherry picked from commit 8f6a5d2)
@yushih @vsubhuman
show hardware-specific messages on tx confirmation dialog
d9c40ff 
(cherry picked from commit 55978c3)
@yushih @vsubhuman
fix progress bar
cb86eb9 
(cherry picked from commit 3170960)
@vsubhuman vsubhuman added this to the 4.5.6 milestone Jul 6, 2021
@vsubhuman vsubhuman requested a review from yushih July 6, 2021 23:46
@vsubhuman vsubhuman changed the title Ledger support backport [4.5.6] Ledger support backport Jul 7, 2021
yushih
yushih approved these changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@yushih yushih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested. LGTM. Thanks.

@vsubhuman vsubhuman merged commit 467df65 into release/4.5.6 Jul 7, 2021
@vsubhuman vsubhuman deleted the ledger-backport branch July 7, 2021 12:17
This was referenced Jul 7, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yushih yushih yushih approved these changes

Assignees
No one assigned
Labels
hardware-wallets
Projects
None yet
Milestone
4.5.6
Development

Successfully merging this pull request may close these issues.
2 participants
@vsubhuman @yushih