Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruslan / Revert my own incorrect flow fix #2228

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Ruslan / Revert my own incorrect flow fix #2228

merged 1 commit into from
Jul 9, 2021

Conversation

vsubhuman
Copy link
Contributor

There was a PR from @yushih : #2214

Which I have ruined with an incorrect Flow fix.
Reverting my incorrect changes now.

@vsubhuman
Revert "Flow"
3603d9c 
This reverts commit 447a14a
@vsubhuman vsubhuman added this to the 4.6.0 milestone Jul 9, 2021
@vsubhuman vsubhuman requested a review from yushih July 9, 2021 10:21
vsubhuman
vsubhuman commented Jul 9, 2021
View reviewed changes
Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

yushih
yushih approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@yushih yushih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This does lead to Flow warning. But the runtime behavior is correct - this.actions.wallets is indeed undefined for Ergo connector app. For now let's ignore the warning until we fix the root cause.

@vsubhuman vsubhuman merged commit ccd9ac2 into develop Jul 9, 2021
@vsubhuman vsubhuman deleted the ruslan/revert-my-incorrect-flow-fix branch July 9, 2021 15:33
@vsubhuman vsubhuman mentioned this pull request Jul 14, 2021
Merged
45 tasks
@yushih yushih mentioned this pull request Jul 15, 2021
Merged
This was referenced Jul 16, 2021
Merged
Merged
@vsubhuman vsubhuman mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yushih yushih yushih approved these changes

Assignees
No one assigned
Labels
revert
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vsubhuman @yushih