Ergo Connector: Fix for large token amounts #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous definition of the TxJson we had had amount/value as just number, but now it accepts number/string so we can fully support values too big for a 53-bit JS number. The dApp example was updated to fully use BigInt as well.
vsubhuman
approved these changes
Jul 14, 2021
This was referenced Jul 14, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous definition of the TxJson we had amount/value as just
number, but now it accepts number/string so we can fully support values
too big for a 53-bit JS number. The dApp example was updated to fully
use BigInt as well.
Fixes #2209