Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameters #204

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Update parameters #204

merged 1 commit into from
Mar 10, 2022

Conversation

forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Mar 4, 2022

Update parameters. Resolves #194.

default.ini:

Tests/docs:

  • On https://e3sm-project.github.io/zppy/_build/html/main/parameters.html, direct users to default.ini rather than keeping a duplicate list of parameters in the docs
  • Alphabetize/update parameters for test_bash_generation.py
  • Alphabetize/update parameters for test_camapign.py
  • Alphabetize/update parameters for test_complete_run.py
  • Get unit tests passing
  • Check if [task] defaults in default.ini override [default] defaults as they would in a user’s cfg. Do this by creating test_defaults.py. Also document how to update the expected files.

After merging:

  • Update expected files for tests and run tests again

@forsyth2 forsyth2 added the semver: bug Bug fix (will increment patch version) label Mar 4, 2022
@forsyth2 forsyth2 self-assigned this Mar 4, 2022
@forsyth2
Copy link
Collaborator Author

forsyth2 commented Mar 4, 2022

@golaz Just FYI, no action needed. This is a nice organizational improvement to our parameters.

Unfortunately, there are 5 cases where I had to decide between 1) specifying a default in multiple sections or 2) specifying a default high up in the inheritance hierarchy and accepting that one section will always override the value. I went with option (2) because even if we don't set the default in the highest-up section, a user could still do so in their configuration file, so we might as well do the same.

Those cases are:

  • [climo] sets nodes = integer(default=4), overriding nodes = integer(default=1)
  • [climo] sets vars = string(default=""), overriding vars = string(default="FSNTOA,FLUT,FSNT,FLNT,FSNS,FLNS,SHFLX,QFLX,TAUX,TAUY,PRECC,PRECL,PRECSC,PRECSL,TS,TREFHT,CLDTOT,CLDHGH,CLDMED,CLDLOW,U")
  • [tc_analysis] sets input_files = string(default="eam.h2"), overriding input_files = string(default="eam.h0")
  • [mpas_analysis] sets walltime = string(default="06:00:00"), overriding walltime = string(default="02:00:00")
  • [global_time_series] sets input_subdir = string(default="archive/ocn/hist"), overriding input_subdir = string(default="archive/atm/hist"

@forsyth2 forsyth2 force-pushed the update-parameters branch from 57bb403 to 2ffb30e Compare March 9, 2022 17:56
@forsyth2 forsyth2 force-pushed the update-parameters branch 2 times, most recently from 4e0bf7a to bff8387 Compare March 9, 2022 23:48
@forsyth2 forsyth2 force-pushed the update-parameters branch from bff8387 to 3047fa1 Compare March 10, 2022 19:33
@forsyth2 forsyth2 marked this pull request as ready for review March 10, 2022 19:44
@forsyth2 forsyth2 merged commit 1c55aab into E3SM-Project:main Mar 10, 2022
@forsyth2 forsyth2 deleted the update-parameters branch March 10, 2022 19:45
@forsyth2 forsyth2 added Testing Files in `tests` modified Documentation Files in `docs` modified labels Mar 10, 2022
@forsyth2 forsyth2 mentioned this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Files in `docs` modified semver: bug Bug fix (will increment patch version) Testing Files in `tests` modified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix inheritance in configuration file
1 participant