Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cfg parameter inheritance hierarchy #212

Closed
forsyth2 opened this issue Mar 10, 2022 · 1 comment
Closed

Improve cfg parameter inheritance hierarchy #212

forsyth2 opened this issue Mar 10, 2022 · 1 comment
Assignees
Labels
priority: low Low priority task

Comments

@forsyth2
Copy link
Collaborator

forsyth2 commented Mar 10, 2022

#204 showed that default values provided in subtasks will override values a user provides higher up in the inheritance hierarchy. This may not be the best behavior. Perhaps the following hierarchy would be better:

  1. Defaults in [default]
  2. Get overridden by defaults in [climo], [ts], etc.
  3. Get overridden by user-provided values in [default]
  4. Get overridden by user-provided values in [climo], [ts], etc.

Note that the current order is 1>3>2>4 (steps 2/3 are flipped). 1>2>3>4 would mean users have the final say whereas the current 1>3>2>4 means the tasks/subtasks have the final say.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Jul 5, 2023

1>2>3>4 would mean users have the final say whereas the current 1>3>2>4 means the tasks/subtasks have the final say.

"2. Get overridden by defaults in [climo], [ts], etc." > "3. Get overridden by user-provided values in [default]": proposed change -- advantage: a user's settings will propagate throughout the tasks/subtasks.

"3. Get overridden by user-provided values in [default]" > "2. Get overridden by defaults in [climo], [ts], etc.": current hierarchy -- advantage: since different tasks/subtasks may have different default values, a user will have to consciously change the task/subtask value, even if setting a default at a higher level.

I believe we agreed that the current hierarchy is sufficient. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Low priority task
Projects
None yet
Development

No branches or pull requests

1 participant