Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ncclimo --parallel command line option #442

Closed
golaz opened this issue Jun 20, 2023 · 3 comments · Fixed by #452
Closed

Expose ncclimo --parallel command line option #442

golaz opened this issue Jun 20, 2023 · 3 comments · Fixed by #452
Labels
semver: new feature New feature (will increment minor version)

Comments

@golaz
Copy link
Collaborator

golaz commented Jun 20, 2023

In some cases, I found it necessary to change the --parallel option in ncclimo to successfully generate time series or climo files with zppy. But zppy currently does not expose that option to the user and so one is forced to manually edit the bash script.

@forsyth2 forsyth2 added the semver: new feature New feature (will increment minor version) label Jul 7, 2023
@forsyth2
Copy link
Collaborator

forsyth2 commented Jul 7, 2023

@golaz ncclimo is called in three places -- twice in climo.bash and once in ts.bash. The 2 climo calls had --parallel=mpi, so in #452 I changed the parameter value to be user-defined. The ts call doesn't use parallel though. Should it be conditionally called depending if the user has set a value for it?

@forsyth2
Copy link
Collaborator

Options:

  • Define parallel = string(default="") in [default], parallel = string(default="mpi") in [climo]. As mentioned in Improve cfg parameter inheritance hierarchy #212, this means that the [climo] default would override a user-provided value in [default]. By default, climo would run with mpi and ts would run without the parallel option at all.
  • Define parallel = string(default="mpi") in [default]. Have ts run with mpi by default, just like climo.

@forsyth2
Copy link
Collaborator

In #452, I go with the first of the above two options, to maintain current functionality by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: new feature New feature (will increment minor version)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants