Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inheritance in configuration file #194

Closed
forsyth2 opened this issue Feb 12, 2022 · 3 comments · Fixed by #204
Closed

Fix inheritance in configuration file #194

forsyth2 opened this issue Feb 12, 2022 · 3 comments · Fixed by #204
Assignees
Labels
semver: bug Bug fix (will increment patch version)

Comments

@forsyth2
Copy link
Collaborator

Specifying mapping_file = /home/ac.zender/data/maps/map_ne30pg2_to_cmip6_180x360_aave.20200201.nc under [default] results in creating <output>/post/atm/native whereas specifying the mapping file under both [climo] and [ts] results in creating <output>/post/atm/180x360_aave/.

It's likely the mapping file specified at https://github.com/E3SM-Project/zppy/blob/main/zppy/templates/default.ini#L20 and https://github.com/E3SM-Project/zppy/blob/main/zppy/templates/default.ini#L44 ends up overriding the value set in [default].

Possible solution: move parameters as high up in the default.ini hierarchy as makes sense.

@forsyth2 forsyth2 added the semver: bug Bug fix (will increment patch version) label Feb 12, 2022
@forsyth2 forsyth2 self-assigned this Feb 12, 2022
@golaz
Copy link
Collaborator

golaz commented Feb 15, 2022

@forsyth2 : good catch! Moving the definition of the default value to the [default] section should solve the problem. It's a good opportunity to go through the list of default values and move non-task specific ones to [default] as well.

@forsyth2
Copy link
Collaborator Author

Note: while addressing this, it may be useful to alphabetize parameters in each section as well.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Mar 3, 2022

It may be good to simply add comments to default.ini and direct users there rather than duplicating the parameter list at https://e3sm-project.github.io/zppy/_build/html/main/parameters.html. (Duplication can go out of date quickly).

@forsyth2 forsyth2 mentioned this issue Mar 4, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: bug Bug fix (will increment patch version)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants