Version Tracking: v3.2.4

[prasannavl]

Items

• Fix for DeFiCh/team#32
  • Move CHistoryWriter into CCustomCSView #1700
• Fix for paybackloanwithcollateral in listaccounthistory #1680
  • Track Add/SubVaultCollateral in vault history #1715
• Temporary mitigation to prevent NEUTRAL votes on the RPC: Neutral vote is mistakenly treated the same as a no-vote for on-chain gov #1704
  • Disable neutral votes from RPC #1709
• Fix setgov crashes #1719
• Wrong Stats in getgovproposal #1721
  • Do not include invalid votes in listgovproposalvotes #1722
  • Display vote validity in listgovproposals and add validity filter #1725
• Add lambda support to Require #1705
• Remove positive amount on close vault #1712
• Track Add/SubVaultCollateral in vault history #1715
• rpc: votegov: Add support for owner and operator address #1717
• Fix for Display vote validity in listgovproposals and add validity filter #1740
  • Display aggregate vote stats in listgovproposalvotes #1714
• Fix incorrect default for cycles argument in listgovproposalvotes #1701
• Fix for Fix staker crash on invalidateblock #1741 and SegFault on invalidate block on staking node #1737
• Fix for Fix getcustomtx crash on mempool transaction #1742 and node crash on getcustomtx of mempool tx, likely createVoc #1739
• Bump version

Verification

• Full reindexed data comparison with 3.2.2 (See below)
  • Account history diff (Reason: Overall accounting impact)
  • Burninfo diff - (Reason: negative interest impact)

[Bushstar]

ain#1700 changes to the CHistoryWriter adds AuctionBid entries to the account history entries that were not present before. These differences can be found on every range since loans were introduced and the first vaults went into liquidation during the range 1,450,000 to 1,500,000.

A sample of this is as follows.

< AccountChange: txid=0000000000000000000000000000000000000000000000000000000000000000 addr=df1qnzmk5a2jcacl8gpsvy5u5ax6mjd5l4v5uwpdmn change=2986.91017100@0
< AccountChange: txid=0000000000000000000000000000000000000000000000000000000000000000 addr=8defichainBurnAddressXXXXXXXdRQkSm change=149.77784424@0
< AccountChange: txid=0000000000000000000000000000000000000000000000000000000000000000 addr=08292842970f420926aefd58084321df9e03b20cde8c8ba37b17c9921b42179c change=0.00000000@26

On all lines the txid is set to zeros, this is due to these changes being outside of a transaction and are processed at the end of a block. PR 1700 updates the txid to hash and where an entry is outside of a transaction the block hash is then used. In addition to this the TX type has been added to AccountChange lines, so for the above would include type=AuctionBid, this is especially useful for non-transaction entries.

Breakdown of the above, first line is the additional of collateral to the auction winner.

ain/src/masternodes/validation.cpp

Line 657 in 0e1a130

view.AddBalance(bidOwner, {tokenId, tokenAmount});

Second line is the transfer of the penalty amount to the burn address.

ain/src/masternodes/validation.cpp

Lines 648 to 649 in 0e1a130

	SwapToDFIorDUSD(view, bidTokenAmount.nTokenId, amountToBurn, tmpAddress,
	chainparams.GetConsensus().burnAddress, pindex->nHeight);

Third line show up from transferring the remaining collateral and penalty amounts using the vault ID as a temporary address. Note that the transfers to the vault ID show as zero as these amounts are later removed from that address.

ain/src/masternodes/validation.cpp

Line 647 in 0e1a130

view.AddBalance(tmpAddress, {bidTokenAmount.nTokenId, amountToBurn});

ain/src/masternodes/validation.cpp

Line 664 in 0e1a130

view.AddBalance(tmpAddress, {bidTokenAmount.nTokenId, amountToFill});

We also have diffs when comparing the output of getburninfo. This is due to the bug fixed in #1700, on start up VerifyDB called DisconnectBlock, changes in DisconnectBlock were supposed to be discarded which is true for CCustomCSView but not for the account, burn and vault databases resulting in records being deleted on start up. Every getburninfo diff now shows an increased amount compared to before.

<     "60290935.19556906@DFI",
<     "2026.29958043@DUSD",
---
>     "60290934.71593739@DFI",
>     "2026.29730296@DUSD",
1819386c1818540
<     "0.15417413@SPY",
---
>     "0.15417366@SPY",
1819412,1819413c1818566,1818567
<     "59.58126593@BTC",
<     "1541877.13814182@DUSD",
---
>     "59.58126588@BTC",
>     "1541873.73817024@DUSD",
1819416c1818570
<     "143.04933253@GME",
---
>     "143.02438253@GME",
1819428,1819429c1818582,1818583
<     "71.87978250@TLT",
<     "5.17667676@AMZN",
---
>     "71.87974551@TLT",
>     "5.17667602@AMZN",

[Bushstar]

Full sync diff of account change of master without PR 1700 and with PR 1700.

full_sync_diff.log

[shohamc1]

RPC Changes

getgovproposal

• Fixed
  • Argument parsing error.
• New output fields added
  • votesNo - number of no votes
  • votesNeutral - number of neutral votes
  • votesInvalid - number of invalid votes (votes by ineligible masternodes)
  • feeRedistributionPerVote - DFI redistributed per voter
  • feeRedistributionTotal - total DFI redistributed to voters
  • approvalThreshold - threshold for number of yes votes for proposal to pass

listgovproposalvotes

• Fixed
  • cycle is set to 1 instead of the current cycle when argument is not set.
  • Argument parsing error.
• New output field added
  • valid: Validity of vote.
  • Note: This is not finalised until the voting period is completed, results may change over time if active masternodes resign before the completion height.
• New arguments
  • aggregate: Returns aggregate voting information about one or more proposals

    • $ ./defi-cli listgovproposalvotes 'b1d19f0a1326655148ebdc967dbf0ffcbbf0bb822069737475c7deac3efc9af1' 'all' 0 true
      [
        {
          "proposalId": "b1d19f0a1326655148ebdc967dbf0ffcbbf0bb822069737475c7deac3efc9af1",
          "total": 100,
          "yes": 50,
          "no": 30,
          "neutral": 20
        }
      ]

    • If no proposal ID is sent, voting information for all of the current proposals are returned
  • valid (default: true): filter results to include only valid or invalid votes

votegov

• masternodeId argument now supports owner and operator address
  • The node will search for masternodes with the provided owner/operator address and use that to vote when an address is provided
  • If a masternode ID is provided, behaviour is unchanged.

  • $ defi-cli votegov b1d19f0a1326655148ebdc967dbf0ffcbbf0bb822069737475c7deac3efc9af1 7Kew9LSBY187dlqX4WVSQZ9SdwAVyKaZ2n "yes"

listvaulthistory

• PaybackWithCollateral transactions are now listed.

  • $ defi-cli listvaulthistory {"txtype": "W"}
    befac9a70c9ea2356456da8c04ca18100c18233dcdbbd5965fba3a0c64e80d6a
    [{'address': 'vaultCollateral', 'blockHeight': 215, 'blockHash': '783748a6e68f05dae0f78dc063bec2a90bf7122dc3bee44b58175cd9ec17bc2f', 'blockTime': 1675931595, 'type': 'PaybackWithCollateral', 'txn': 1, 'txid': 'b80a593ed538142bc4c68e3acd729a839fb890b2c2e1bb6234e7b5db3bd8297f', 'amounts': ['-1.00001142@DUSD']}]

getcustomtx

• Fixed crash when decoding unconfirmed CreateVoc transactions

[defichain-bot]

@prasannavl: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.