Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display aggregate vote stats in listgovproposalvotes #1714

Merged
merged 15 commits into from
Feb 7, 2023

Conversation

shohamc1
Copy link
Contributor

@shohamc1 shohamc1 commented Jan 30, 2023

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #1708

Additional comments?:

When no arguments are provided, votes for all masternodes for all proposals in the current cycle will be tallied.

Some behaviour fixes dependant on #1701

@shohamc1 shohamc1 marked this pull request as ready for review February 1, 2023 07:11
@prasannavl prasannavl mentioned this pull request Feb 9, 2023
19 tasks
@shohamc1 shohamc1 requested review from Bushstar, Jouzo and Mixa84 February 1, 2023 07:16
# Conflicts:
#	src/masternodes/rpc_proposals.cpp
#	test/functional/feature_on_chain_government.py
@Mixa84 Mixa84 added v/3.2.4 and removed v/3.2.3 labels Feb 3, 2023
@Bushstar Bushstar merged commit ae17b96 into master Feb 7, 2023
@Bushstar Bushstar deleted the proposalvotes-stats branch February 7, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display aggregate vote stats in listgovproposalvotes
6 participants