Neutral vote is mistakenly treated the same as a no-vote for on-chain gov

[uzyn]

Caution

As on-chain governance is activated soon and likely before this consensus error is able to be fixed, do not cast neutral votes before this bug is addressed or it would be counted as a no-vote.

Bug

What happened:

Neutral votes for CFP and VoC are counted the same as no-votes, it should not be that way.

Reference:

ain/src/masternodes/validation.cpp

Lines 2235 to 2238 in 0989ff6

	if (lround(voteYes * 10000.f / voters.size()) <= prop.approvalThreshold) {
	cache.UpdateProposalStatus(propId, pindex->nHeight, CProposalStatusType::Rejected);
	return true;
	}

Example:

• 1000 yesses, 200 nos, 5000 neutrals are currently mistakently marked as a failed CFP/DFIP.

What you expected to happen:

Neutral votes for CFP and VoC should not be counted as no-votes.

Example:

• 1000 yesses, 200 nos, 5000 neutrals should be counted as a passing CFP/DFIP.

[defichain-bot]

@uzyn: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.