Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCG voting scenarios tests #1706

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Add OCG voting scenarios tests #1706

merged 2 commits into from
Jan 27, 2023

Conversation

Jouzo
Copy link
Collaborator

@Jouzo Jouzo commented Jan 25, 2023

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Adds OCG voting scenarios tests

Which issue(s) does this PR fixes?:

Illustrates issue caught in #1704
Fixes https://github.com/DeFiCh/team/issues/10#issuecomment-1403418835 in https://github.com/DeFiCh/team/issues/10

@Jouzo Jouzo force-pushed the test/voting_scenarios branch 3 times, most recently from 1a9c833 to a342fc9 Compare January 26, 2023 07:59
@Jouzo Jouzo marked this pull request as ready for review January 26, 2023 08:00
@Jouzo Jouzo force-pushed the test/voting_scenarios branch from 01fbd0a to 24eb10c Compare January 26, 2023 08:19
@dcorral
Copy link
Contributor

dcorral commented Jan 26, 2023

Run rollback on each scenario and check the state of the chain pre and post rollback. Use -simulatemainnet=1 to have tests closer to mainnet behaviour.

@Jouzo Jouzo force-pushed the test/voting_scenarios branch from 24eb10c to d04b8aa Compare January 26, 2023 08:41
@prasannavl prasannavl merged commit 68d44fb into master Jan 27, 2023
@prasannavl prasannavl deleted the test/voting_scenarios branch January 27, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants